You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by Richard Eckart de Castilho <re...@apache.org> on 2020/04/15 11:38:23 UTC

[VOTE] Release UIMA uimaFIT 2.5.0 RC1

Hi,

I've posted the uimaFIT 2.5.0 release candidate 1.


uimaFIT 2.5.0 is a minor feature and bugfix release. On supported platforms, it should should serve
as a drop-in replacement for previous uimaFIT 2.x versions.

Changes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310570&version=12339544

The source and binary tar/zips are here:
https://dist.apache.org/repos/dist/dev/uima/uimafit/2.5.0-rc1/

The Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapacheuima-1250

The GIT tag is here:
https://github.com/apache/uima-uimafit/tree/uimafit-2.5.0

Clone using: git clone -b uimafit-2.5.0 https://github.com/apache/uima-uimafit.git

See http://uima.apache.org/testing-builds.html for suggestions on how to test
release candidates.

Please vote on release:

[ ] +1 OK to release
[ ] 0   Don't care
[ ] -1 Not OK to release, because ...

Thanks.

-- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1 - .settings files in the tag?

Posted by Richard Eckart de Castilho <re...@apache.org>.
Hi,

> On 17. Apr 2020, at 21:49, Marshall Schor <ms...@schor.com> wrote:
> 
> I noticed that the git checkout of the uimafit-2.5.0 tag has
> Eclipse .settings files for the Java projects.
> 
> I  think these are normally not checked into git?
> 
> Is this intentional?

It is intentional, yes. It is not great, but what they mostly do is configure the code style/formatting because for uimaFIT I use a different code style (UIMA style) than for all other projects in my workspace.

-- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1 - .settings files in the tag?

Posted by Marshall Schor <ms...@schor.com>.
Hi, I'm working on this...

I noticed that the git checkout of the uimafit-2.5.0 tag has
Eclipse .settings files for the Java projects.

I  think these are normally not checked into git?

Is this intentional?

-Marshall



[CANCEL] [VOTE] Release UIMA uimaFIT 2.5.0 RC1

Posted by Richard Eckart de Castilho <re...@apache.org>.
Considering that I have meanwhile fixed the issues found/commented on by Marshall regarding builds on recent JDKs, let's cancel this one and do a new RC with the fixes in.

Cheers,

-- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1

Posted by Richard Eckart de Castilho <re...@apache.org>.
Hi,

> On 19. Apr 2020, at 06:11, Marshall Schor <ms...@schor.com> wrote:
> 
> actually, this might not be the right fix.
> 
> Imagine - perhaps there's some way to fix the serialization in Java 9+ for xml
> so it didn't add extra blank lines...

When I first encountered this issue way back when Java 9 came out, I tried to
track it down but I couldn't figure out where the extra newlines came from.

> That would be better, I think, rather than making the test ignore this.

I guess since you tripped over it, for the moment may be better to ignore it
so the stuff builds on current JDKs. In any case, I'm pretty sure it is not
an issue in uimaFIT but rather something we should test and investigate
in the context oft he core framework.

> The announcement might include a note that the build works on Java 8, and has
> some minor issues with Java 9+

Ok. I hope I don't forget it :)

-- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1

Posted by Marshall Schor <ms...@schor.com>.
actually, this might not be the right fix.

Imagine - perhaps there's some way to fix the serialization in Java 9+ for xml
so it didn't add extra blank lines...

That would be better, I think, rather than making the test ignore this.


I'm fine with going with your judgement of the importance of getting out the
changes fixed so far, versus waiting to include even more fixes...

The announcement might include a note that the build works on Java 8, and has
some minor issues with Java 9+

-Marshall

On 4/18/2020 2:11 PM, Richard Eckart de Castilho wrote:
> On 18. Apr 2020, at 16:11, Marshall Schor <ms...@schor.com> wrote:
>> Do you intend this to be buildable with later Java's?  (No errors with Oracle
>> Java 8)
> I would not mind getting it out building against Java 8 only at this time.
> My suspicion is that most people don't build it anyway but use the pre-built
> binaries from Maven Central.
>
>> XMLUnit.setIgnoreWhitespace(true);
> Thanks for figuring that out :)
>
> So what do you think? Should we cancel the RC and fix the test for recent JDKs
> or proceed?
>
> Btw. the same failure also affects the uimaFIT v3 RC.
>
> -- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1

Posted by Richard Eckart de Castilho <re...@apache.org>.
On 18. Apr 2020, at 16:11, Marshall Schor <ms...@schor.com> wrote:
> 
> Do you intend this to be buildable with later Java's?  (No errors with Oracle
> Java 8)

I would not mind getting it out building against Java 8 only at this time.
My suspicion is that most people don't build it anyway but use the pre-built
binaries from Maven Central.

> XMLUnit.setIgnoreWhitespace(true);

Thanks for figuring that out :)

So what do you think? Should we cancel the RC and fix the test for recent JDKs
or proceed?

Btw. the same failure also affects the uimaFIT v3 RC.

-- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1

Posted by Marshall Schor <ms...@schor.com>.
Javadoc errors, when building with Oracle Java 14 in uimafit-core:

[ERROR] Exit code: 1 -
C:\au\t\uimaFIT\2.5.0\rc1\uimafit-2.5.0-bfs\uimafit-core\src\main\java\org\apache\uima\fit\internal\ResourceManagerFactory.java:55:
warning: no @param for resourceManagerCreator
[ERROR]   public static synchronized void setResourceManagerCreator(
[ERROR]                                   ^
[ERROR]
C:\au\t\uimaFIT\2.5.0\rc1\uimafit-2.5.0-bfs\uimafit-core\src\main\java\org\apache\uima\fit\factory\package-info.java:22:
error: heading used out of sequence: <H3>, compared to implicit preceding
heading: <H1>
[ERROR]  * <h3><a name="InstancesVsDescriptors">Why are descriptors better than
component instances?</a></h3>
[ERROR]    ^
[ERROR]
C:\au\t\uimaFIT\2.5.0\rc1\uimafit-2.5.0-bfs\uimafit-core\src\main\java\org\apache\uima\fit\factory\package-info.java:22:
error: attribute not supported in HTML5: name
[ERROR]  * <h3><a name="InstancesVsDescriptors">Why are descriptors better than
component instances?</a></h3>
[ERROR]           ^
[ERROR]
C:\au\t\uimaFIT\2.5.0\rc1\uimafit-2.5.0-bfs\uimafit-core\src\main\java\org\apache\uima\fit\util\package-info.java:22:
error: heading used out of sequence: <H3>, compared to implicit preceding
heading: <H1>
[ERROR]  * <h3><a name="SortOrder">Sort order</a></h3>
[ERROR]    ^
[ERROR]
C:\au\t\uimaFIT\2.5.0\rc1\uimafit-2.5.0-bfs\uimafit-core\src\main\java\org\apache\uima\fit\util\package-info.java:22:
error: attribute not supported in HTML5: name
[ERROR]  * <h3><a name="SortOrder">Sort order</a></h3>
[ERROR]           ^


Do you intend this to be buildable with later Java's?  (No errors with Oracle
Java 8)


Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1

Posted by Richard Eckart de Castilho <re...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

* Build from sources zip (using Java 8): ok
  Note: there is a unit test involving XML which currently fails on Java >8
        due to minor changes in the XML serialization between the JDKs.
        Eventually, the test needs to be improved.
* Checked README: ok
* Checked fixed issues: ok
* Checked API changes report: ok
* Compared git tag vs sources ZIP: ok
* Built DKPro Core against the staged RC: ok
* Checked NOTICE and LICENSE files in the binary release: ok
  Note: there was an update of Spring which affected these

[X] +1 OK to release

- -- Richard
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPY2MKJLmMo4NDQCrO8wPPFbjAA4FAl6W8lJfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNE
OEQ4QzI4OTJFNjMyOEUwRDBEMDBBQjNCQ0MwRjNDNTZFMzAwMEUACgkQO8wPPFbj
AA6wfRAAqppVovS8lV/t/trp44fLW7uNO7T06rm+tcqMjHyASibQSJcvbTeaVK2I
w5zgrpsMQx+Ee+pteH7Vf5AeVXarOVN12C3SeqE40Z+V7jf8aonn3gsUR8QkPtp0
Chqae0Xljra9amM+tT7NjPfqbk72bHaXHIRWBdmpkIgAVL5qqpFK0RCMSVvkf5GH
cOkrzlTsQE1kd8n6+4jEsfzwuFKYWdEQIOjt0JOzQBtZnGyozWVe4WfjL3ItwpYD
6FweMsi3zfuA36ZVdCeeah4W0X1vyVCsEGO0aW9V4hshrmn0RrCm42HeoI/NfjV0
rxplW3FdISrykIPIa+JFFDLq/B97xLU2i5hsIptPB8xr9kAbyvalenteVmMtr+3r
e27keBakayafn7XEo2BW/rv+UWmmtsa+n8TUcZxItCKvrsMYWdruL4FGqsysXOMN
QfzcOlf+g/hpLCZEQ/npU5LihI7jkSOvz9kQ6ckKlq4BQUABRZrBc9Rg4zNrOdTr
qdctCeoMkKa06GCnqWIEODHEKLgaQAbyegMXD9PktiPRzJoB3YTRNbQRDzLxb+h9
ILHA6TWRTTSD7uRBGxx4yrJwYhbgWB2YERPV+ETVS2Md5jSfll4QiWhYuxZNtoXw
9ztQi6cFV2WIFgh7bDdmBq3OCjK5VeR8vq1OylhxjsGJp6mQFZg=
=6HYp
-----END PGP SIGNATURE-----


Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1

Posted by Marshall Schor <ms...@schor.com>.
this problem too went away when switching back to Java 8 from Java 13.

-Marshall

On 4/17/2020 4:18 PM, Marshall Schor wrote:
> Running the build-from-source, at an early phase it issued the messages:
>
> [INFO] --- gmaven-plugin:1.5:execute (read-notice) @ uimafit-parent ---
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.codehaus.groovy.reflection.CachedClass$3$1
> (file:/C:/Users/MarshallSchor/.m2/repository/org/codehaus/groovy/groovy-all/1.6.9/groovy-all-1.6.9.jar)
> to method java.lang.Object.finalize()
> WARNING: Please consider reporting this to the maintainers of
> org.codehaus.groovy.reflection.CachedClass$3$1
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
>
> WARNING: All illegal access operations will be denied in a future release
>
> Does this matter? -Marshall
>

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1

Posted by Richard Eckart de Castilho <re...@apache.org>.
Hi,

> On 17. Apr 2020, at 22:18, Marshall Schor <ms...@schor.com> wrote:
> 
> Running the build-from-source, at an early phase it issued the messages:
> 
> [INFO] --- gmaven-plugin:1.5:execute (read-notice) @ uimafit-parent ---
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.codehaus.groovy.reflection.CachedClass$3$1
> (file:/C:/Users/MarshallSchor/.m2/repository/org/codehaus/groovy/groovy-all/1.6.9/groovy-all-1.6.9.jar)
> to method java.lang.Object.finalize()
> WARNING: Please consider reporting this to the maintainers of
> org.codehaus.groovy.reflection.CachedClass$3$1
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> 
> WARNING: All illegal access operations will be denied in a future release
> 
> Does this matter?

Not really. That happens when you run Groovy on any recent JDK. 

It seems it might have been fixed in Groovy 3 which has been released
earlier this year in February:

  https://issues.apache.org/jira/browse/GROOVY-8339

  https://search.maven.org/artifact/org.codehaus.groovy/groovy-all

I'll look into upgrading the Groovy version used in the build to avoid
this issue going forward, but IMHO it shouldn't be a blocker for the
present release candidate.

The same warning will appear for the uimaFIT v3 candidate.

Cheers,

-- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1

Posted by Marshall Schor <ms...@schor.com>.
Running the build-from-source, at an early phase it issued the messages:

[INFO] --- gmaven-plugin:1.5:execute (read-notice) @ uimafit-parent ---
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by
org.codehaus.groovy.reflection.CachedClass$3$1
(file:/C:/Users/MarshallSchor/.m2/repository/org/codehaus/groovy/groovy-all/1.6.9/groovy-all-1.6.9.jar)
to method java.lang.Object.finalize()
WARNING: Please consider reporting this to the maintainers of
org.codehaus.groovy.reflection.CachedClass$3$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal
reflective access operations

WARNING: All illegal access operations will be denied in a future release

Does this matter? -Marshall


Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1

Posted by Marshall Schor <ms...@schor.com>.
This "fix" makes the test work:

1) add an import: import org.custommonkey.xmlunit.XMLUnit;

2) in front of the failing line ( XMLAssert.assertXMLEqual(expected, actual); )
add this line:

XMLUnit.setIgnoreWhitespace(true);

Cheers. -M

On 4/17/2020 5:18 PM, Marshall Schor wrote:
> found the problem. 
>
> I was doing the build with Java 13.
>
> Switched back to Java 8 and it worked.
>
> In Java 13, the serialization has extra blank lines in the output.
> Maybe there's a way to configure the XML compare utility to ignore this?
>
> -Marshall
>
>
> On 4/17/2020 4:24 PM, Marshall Schor wrote:
>> When doing build from sources, during the testing of the uimafit-core,
>>
>> it got
>>
>> [INFO] Running org.apache.uima.fit.factory.AnalysisEngineFactoryTest
>> Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
>> INFO: Package installer message: [InstallationController]: extracting
>> C:\au\t\uimaFIT\2.5.0\rc1\uimafit-2.5.0-bfs\uimafit-core\src\test\resources\pear\DateTime.pear
>>
>> Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
>> INFO: Package installer message: [InstallationController]: 44271 bytes extracted
>>
>> Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
>> INFO: Package installer message: [InstallationProcessor]: start processing InsD
>> file -
>> C:\au\t\uimaFIT\2.5.0\rc1\uimafit-2.5.0-bfs\uimafit-core\target\test-output\AnalysisEngineFactoryTest\testPear\uima.example.DateTimeAnnotator\metadata\install.xml
>>
>> Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
>> INFO: Package installer message: [InstallationController]: the
>> metadata/setenv.txt file contains required environment variables for this component
>> [InstallationController]: component uima.example.DateTimeAnnotator installation
>> completed.
>>
>> Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
>> INFO: Installation verification of component uima.example.DateTimeAnnotator
>> successfully completed.
>> Apr 17, 2020 4:13:04 PM org.apache.uima.tutorial.ex3.TutorialDateTime process(159)
>> WARNING: No output is being produced by the TutorialDateTime annotator because
>> the Result Specification did not contain a request for the type
>>   org.apache.uima.tutorial.TimeAnnot nor
>>   org.apache.uima.tutorial.DateAnnot with the language 'en'
>>   (Note: this message will only be shown once.)
>>
>> [ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.343 s
>> <<< FAILURE! - in org.apache.uima.fit.factory.AnalysisEngineFactoryTest
>> [ERROR]
>> serializeComponent(org.apache.uima.fit.factory.AnalysisEngineFactoryTest)  Time
>> elapsed: 0.048 s  <<< FAILURE!
>> junit.framework.AssertionFailedError:
>> org.custommonkey.xmlunit.Diff
>> [different] Expected text value '
>>     ' but was '
>>
>>     ' - comparing <analysisEngineDescription ...>
>>     </analysisEngineDescription> at /analysisEngineDescription[1]/text()[1] to
>> <analysisEngineDescription ...>
>>
>>     </analysisEngineDescription> at /analysisEngineDescription[1]/text()[1]
>>
>>         at
>> org.apache.uima.fit.factory.AnalysisEngineFactoryTest.serializeComponent(AnalysisEngineFactoryTest.java:567)
>>
>>
>> Do I have something configured incorrectly?
>>
>> -Marshall
>>

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1

Posted by Marshall Schor <ms...@schor.com>.
found the problem. 

I was doing the build with Java 13.

Switched back to Java 8 and it worked.

In Java 13, the serialization has extra blank lines in the output.
Maybe there's a way to configure the XML compare utility to ignore this?

-Marshall


On 4/17/2020 4:24 PM, Marshall Schor wrote:
> When doing build from sources, during the testing of the uimafit-core,
>
> it got
>
> [INFO] Running org.apache.uima.fit.factory.AnalysisEngineFactoryTest
> Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
> INFO: Package installer message: [InstallationController]: extracting
> C:\au\t\uimaFIT\2.5.0\rc1\uimafit-2.5.0-bfs\uimafit-core\src\test\resources\pear\DateTime.pear
>
> Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
> INFO: Package installer message: [InstallationController]: 44271 bytes extracted
>
> Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
> INFO: Package installer message: [InstallationProcessor]: start processing InsD
> file -
> C:\au\t\uimaFIT\2.5.0\rc1\uimafit-2.5.0-bfs\uimafit-core\target\test-output\AnalysisEngineFactoryTest\testPear\uima.example.DateTimeAnnotator\metadata\install.xml
>
> Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
> INFO: Package installer message: [InstallationController]: the
> metadata/setenv.txt file contains required environment variables for this component
> [InstallationController]: component uima.example.DateTimeAnnotator installation
> completed.
>
> Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
> INFO: Installation verification of component uima.example.DateTimeAnnotator
> successfully completed.
> Apr 17, 2020 4:13:04 PM org.apache.uima.tutorial.ex3.TutorialDateTime process(159)
> WARNING: No output is being produced by the TutorialDateTime annotator because
> the Result Specification did not contain a request for the type
>   org.apache.uima.tutorial.TimeAnnot nor
>   org.apache.uima.tutorial.DateAnnot with the language 'en'
>   (Note: this message will only be shown once.)
>
> [ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.343 s
> <<< FAILURE! - in org.apache.uima.fit.factory.AnalysisEngineFactoryTest
> [ERROR]
> serializeComponent(org.apache.uima.fit.factory.AnalysisEngineFactoryTest)  Time
> elapsed: 0.048 s  <<< FAILURE!
> junit.framework.AssertionFailedError:
> org.custommonkey.xmlunit.Diff
> [different] Expected text value '
>     ' but was '
>
>     ' - comparing <analysisEngineDescription ...>
>     </analysisEngineDescription> at /analysisEngineDescription[1]/text()[1] to
> <analysisEngineDescription ...>
>
>     </analysisEngineDescription> at /analysisEngineDescription[1]/text()[1]
>
>         at
> org.apache.uima.fit.factory.AnalysisEngineFactoryTest.serializeComponent(AnalysisEngineFactoryTest.java:567)
>
>
> Do I have something configured incorrectly?
>
> -Marshall
>

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC1

Posted by Marshall Schor <ms...@schor.com>.
When doing build from sources, during the testing of the uimafit-core,

it got

[INFO] Running org.apache.uima.fit.factory.AnalysisEngineFactoryTest
Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
INFO: Package installer message: [InstallationController]: extracting
C:\au\t\uimaFIT\2.5.0\rc1\uimafit-2.5.0-bfs\uimafit-core\src\test\resources\pear\DateTime.pear

Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
INFO: Package installer message: [InstallationController]: 44271 bytes extracted

Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
INFO: Package installer message: [InstallationProcessor]: start processing InsD
file -
C:\au\t\uimaFIT\2.5.0\rc1\uimafit-2.5.0-bfs\uimafit-core\target\test-output\AnalysisEngineFactoryTest\testPear\uima.example.DateTimeAnnotator\metadata\install.xml

Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
INFO: Package installer message: [InstallationController]: the
metadata/setenv.txt file contains required environment variables for this component
[InstallationController]: component uima.example.DateTimeAnnotator installation
completed.

Apr 17, 2020 4:13:04 PM PackageInstaller installPackage
INFO: Installation verification of component uima.example.DateTimeAnnotator
successfully completed.
Apr 17, 2020 4:13:04 PM org.apache.uima.tutorial.ex3.TutorialDateTime process(159)
WARNING: No output is being produced by the TutorialDateTime annotator because
the Result Specification did not contain a request for the type
  org.apache.uima.tutorial.TimeAnnot nor
  org.apache.uima.tutorial.DateAnnot with the language 'en'
  (Note: this message will only be shown once.)

[ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.343 s
<<< FAILURE! - in org.apache.uima.fit.factory.AnalysisEngineFactoryTest
[ERROR]
serializeComponent(org.apache.uima.fit.factory.AnalysisEngineFactoryTest)  Time
elapsed: 0.048 s  <<< FAILURE!
junit.framework.AssertionFailedError:
org.custommonkey.xmlunit.Diff
[different] Expected text value '
    ' but was '

    ' - comparing <analysisEngineDescription ...>
    </analysisEngineDescription> at /analysisEngineDescription[1]/text()[1] to
<analysisEngineDescription ...>

    </analysisEngineDescription> at /analysisEngineDescription[1]/text()[1]

        at
org.apache.uima.fit.factory.AnalysisEngineFactoryTest.serializeComponent(AnalysisEngineFactoryTest.java:567)


Do I have something configured incorrectly?

-Marshall


[CANCEL] [VOTE] Release UIMA uimaFIT 3.1.0 RC1

Posted by Richard Eckart de Castilho <re...@apache.org>.
Considering that I have meanwhile fixed the issues found/commented on by Marshall on the v2.5.0-RC1 regarding builds on recent JDKs (which also apply to this RC), let's cancel this one and do a new RC with the fixes in.

Cheers,

-- Richard