[GitHub] ert78gb commented on issue #63: style: add .editorconfig, eslint and reformat js file

[GitBox <gi...@apache.org>]

ert78gb commented on issue #63: style: add .editorconfig, eslint and reformat js file
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/63#issuecomment-377790799
 
 
   Hi @csantanapr and @jthomas ,
   
   First of all, sorry for my late response but I was extremely busy in the last few month. 
   
   I reverted the constructor parameters to the old style and the documentation too.
   
   I suggest to increase major version number when you release a new version, because if someone use "private" method of an object it may cause breaks. Example if someone used the lib/action.js -> action_body method it renamed to actionBody. 
   
   I have a few other refactoring suggestion. Example: use pure function instead if object method and the method use only input parameters of the method lib/action.js -> actionBody with this technic you could minimalized the api exposition
   
   Happy holidays,
   Robi

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services