[GitHub] [airflow] potiuk edited a comment on pull request #12599: Restrict "build images" workflow to certain branches

[GitBox <gi...@apache.org>]

potiuk edited a comment on pull request #12599:
URL: https://github.com/apache/airflow/pull/12599#issuecomment-733755212


   Sorry - been distracted yesterday. 
   
   I look up the specification https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#workflow_run and I think it should be simply limited via "branches" not based on event type relly. The "worklfow_run" can be triggered by:
   
   1) push
   2) pull 
   3) schedule 
   
   From the docs, it seems that this can be achieved by simply adding  "branches" without specifying the event that triggers it. We are already limited to those three triggering events because the depending "workflow" only runs on PR/Push/Schedule:: 
   
   ```
   on:
     workflow_run:
       workflows: ["Run Tests"]
       branches: [main]
       types: 
         - completed
         - requested
   
   ```
   
   But I think it should be tested. The best way (and the way I tested it ) was to push it to my own fork and test it there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org