[GitHub] [beam] piotr-szuberski commented on a change in pull request #12780: [BEAM-5504] Add Pubsub Avro table provider

[GitBox <gi...@apache.org>]

piotr-szuberski commented on a change in pull request #12780:
URL: https://github.com/apache/beam/pull/12780#discussion_r494198255



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/DropFields.java
##########
@@ -85,9 +85,8 @@ private Inner(FieldAccessDescriptor fieldsToDrop) {
 
     FieldAccessDescriptor complement(Schema inputSchema, FieldAccessDescriptor input) {
       // Create a FieldAccessDescriptor that select all fields _not_ selected in the input
-      // descriptor. Maintain
-      // the original order of the schema.
-      Set<String> fieldNamesToSelect = Sets.newHashSet();
+      // descriptor. Maintain the original order of the schema.
+      List<String> fieldNamesToSelect = newArrayList();

Review comment:
       You're definitely right, I've done it here:  https://github.com/apache/beam/pull/12928




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org