You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/09 23:55:06 UTC
[GitHub] [kafka] hachikuji opened a new pull request #9277: MINOR: Fix JSON generation of nested structs with non-matching type/name
hachikuji opened a new pull request #9277:
URL: https://github.com/apache/kafka/pull/9277
The schema specification allows a struct type name to differ from the field name. This works with the generated `Message` classes, but not with the generated JSON converter. The problem seems to be that the type name gets replaced with the field name when the struct is registered.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #9277: MINOR: Fix JSON generation of nested structs with non-matching type/name
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #9277:
URL: https://github.com/apache/kafka/pull/9277#issuecomment-689896549
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #9277: MINOR: Fix JSON generation of nested structs with non-matching type/name
Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #9277:
URL: https://github.com/apache/kafka/pull/9277
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #9277: MINOR: Fix JSON generation of nested structs with non-matching type/name
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #9277:
URL: https://github.com/apache/kafka/pull/9277#issuecomment-690706923
One flaky failure which is fixed by #9091. Will merge to trunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org