You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/02/11 20:30:12 UTC

[Bug 4134] New: Add easier access to "spam reported to..." messages

http://bugzilla.spamassassin.org/show_bug.cgi?id=4134

           Summary: Add easier access to "spam reported to..." messages
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Learner
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: snowsam@laurel-point.net


Request for an enhancement:

Currently when reporting spam/ham from the command line you your confirmation 
that the process completed is the returned text "Learned from 1 message(s) (1 
message(s) examined)." This was added via tracker # 2268 ( see 
http://bugzilla.spamassassin.org/show_bug.cgi?id=2268 ). 

In order to know which external services have successfully been reported to you 
can run spamassassin -r in debug mode and look for the interesting lines:

debug: SpamAssassin: spam reported to DCC.
debug: SpamAssassin: spam reported to Pyzor.
debug: SpamAssassin: spam reported to Razor.
debug: SpamAssassin: spam reported to SpamCop.

My enhancement suggestion is to add this information to the normal output. One 
way to do this would be to add a new command line switch that would allow this 
information to be shown without getting the full debug information (but leaving 
the default invocation results as-is).

Sam



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4134] Add easier access to "spam reported to..." messages

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4134





------- Additional Comments From quinlan@pathname.com  2005-02-11 12:59 -------
Subject: Re:  Add easier access to "spam reported to..." messages

> I think the reason it doesn't tell you now is that you could be doing
> multiple messages.  Seeing 400 of those is annoying, and it's
> meaningless to only show it for some and not all.

Yep, and I don't really want to muck up the code with N different
switches and tons of code to handle 1 message vs. many messages and
"quiet" vs. "semi-verbose" vs. "verbose.

This seems like a reasonable place to use the distinction between info()
and dbg(), though.  One line of output per message per method is
info()-able, I think.  I have a patch that I'll commit and then I think
we can close this bug.  It wouldn't be hard to revert if people object.
;-)

Daniel





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4134] Add easier access to "spam reported to..." messages

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4134





------- Additional Comments From felicity@kluge.net  2005-02-11 12:37 -------
Subject: Re:  Add easier access to "spam reported to..." messages

On Fri, Feb 11, 2005 at 12:31:44PM -0800, bugzilla-daemon@bugzilla.spamassassin.org wrote:
> I propose we add info() support to Plugin.pm, then change those (the
> report yes vs. no message) to simply be an informational message.  So,
> if you call sa-filter with -Dinfo as follows, you get the informational
> reporting messages:
> 
>   $ sa-filter -Dinfo -r < /tmp/newspam
>   info: generic: SpamAssassin version 3.1.0-r151785
>   info: reporter: spam reported to DCC
>   info: reporter: spam reported to Pyzor
>   info: reporter: spam reported to Razor
>   info: reporter: spam reported to SpamCop
>   1 message(s) examined.

I think the reason it doesn't tell you now is that you could be doing multiple
messages.  Seeing 400 of those is annoying, and it's meaningless to only show
it for some and not all.





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4134] Add easier access to "spam reported to..." messages

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4134


quinlan@pathname.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dev@spamassassin.apache.org
         AssignedTo|dev@spamassassin.apache.org |quinlan@pathname.com




------- Additional Comments From quinlan@pathname.com  2005-02-11 19:06 -------
taking bug




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.

[Bug 4134] Add easier access to "spam reported to..." messages

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4134


quinlan@pathname.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From quinlan@pathname.com  2005-02-11 19:06 -------
closing as fixed, I checked the info() change into HEAD




------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug 4134] Add easier access to "spam reported to..." messages

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4134





------- Additional Comments From quinlan@pathname.com  2005-02-11 12:31 -------
Subject: Re:   New: Add easier access to "spam reported to..." messages

> My enhancement suggestion is to add this information to the normal
> output. One way to do this would be to add a new command line switch
> that would allow this information to be shown without getting the full
> debug information (but leaving the default invocation results as-is).

Definitely -1 on addition of new switches.

I propose we add info() support to Plugin.pm, then change those (the
report yes vs. no message) to simply be an informational message.  So,
if you call sa-filter with -Dinfo as follows, you get the informational
reporting messages:

  $ sa-filter -Dinfo -r < /tmp/newspam
  info: generic: SpamAssassin version 3.1.0-r151785
  info: reporter: spam reported to DCC
  info: reporter: spam reported to Pyzor
  info: reporter: spam reported to Razor
  info: reporter: spam reported to SpamCop
  1 message(s) examined.

(note: "spamassassin" is called "sa-filter" in 3.1, although the old
name of "spamassassin" still works for now.)





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.