You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/11/05 17:04:41 UTC

[GitHub] [orc] pgaref commented on a change in pull request #562: ORC-683: PPD: Make Floating point NaN check more strict

pgaref commented on a change in pull request #562:
URL: https://github.com/apache/orc/pull/562#discussion_r518211668



##########
File path: java/core/src/test/org/apache/orc/TestVectorOrcFile.java
##########
@@ -4025,7 +4025,7 @@ public void testPredicatePushdownWithNan() throws Exception {
 
     DoubleColumnVector dbcol = ((DoubleColumnVector) batch.cols[0]);
 
-    // first row NaN (resulting to both min and max columnStats of stride to be NaN)
+    // first row NaN (resulting to  min/max and sum columnStats of stride to be NaN)

Review comment:
       sure, fixed! 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org