[GitHub] [skywalking] wu-sheng commented on a change in pull request #7975: support search browser service

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #7975:
URL: https://github.com/apache/skywalking/pull/7975#discussion_r733353167



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/query/IMetadataQueryDAO.java
##########
@@ -44,16 +45,18 @@
     List<Database> getAllDatabases() throws IOException;
 
     /**
-     * @param keyword to filter the normal service
+     * @param nodeType describe which kind of node of Service
+     * @param keyword  to filter the normal service
      * @return the list of normal services matching the given keyword
      */
-    List<Service> searchServices(final String keyword) throws IOException;
+    List<Service> searchServices(final NodeType nodeType, final String keyword) throws IOException;
 
     /**
+     * @param nodeType    describe which kind of node of Service
      * @param serviceCode to literal match
      * @return the service matching the given full name.
      */
-    Service searchService(final String serviceCode) throws IOException;
+    Service searchService(final NodeType nodeType, final String serviceCode) throws IOException;

Review comment:
       FYI @LIU-WEI-git This PR will be merged soon and it breaks your implementation a little. Please take a look.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org