[GitHub] [mina-sshd] lgoldstein commented on pull request #217: [SSHD-966] Flush pending packets asynchronously at end of KEX

[GitBox <gi...@apache.org>]

lgoldstein commented on PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#issuecomment-1100578622

   @tomaswolf The code is very complex and I am having a hard time following it - this is in no way criticism on it since I am aware of the complexity of the issue and the initial code state so I can truly appreciate the effort. I have reviewed it only from "30,000 feet" so to speak and nothing special stands out - however, I do admit I was not able to run through its logic with a fine toothcomb. My point is that I don't feel I can do justice to it so I trust you have reviewed it, thought about and tested it **thoroughly** since it touches on a most sensitive and crucial piece of the entire project. I appreciate the effort that must have gone into it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org