[GitHub] [iceberg] zhaomin1423 commented on pull request #5346: Substitute the method of PropertyUtil#propertyAsLong for IcebergSource#propertyAsLong

[GitBox <gi...@apache.org>]

zhaomin1423 commented on PR #5346:
URL: https://github.com/apache/iceberg/pull/5346#issuecomment-1210054609

   > @zhaomin1423 actually do you mind doing the same change for other spark versions? I feel normally we do feature for specific spark version(s), but for something like this that's purely cosmetic, would prefer to keep the code synchronized so its easier to backport changes if necessary.
   
   Sorry for late reply. I'm wondering, why not use a common module or abstract class for repeated logical.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org