You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2018/07/10 11:28:12 UTC

[GitHub] carbondata pull request #2479: [CARBONDATA-2542][MV] Fix the mv query from t...

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/2479

    [CARBONDATA-2542][MV] Fix the mv query from table with different database 

    This PR depends on https://github.com/apache/carbondata/pull/2453
    Problem: database name is not added to the table name while generating mv query.
    Solution: Add the database name to the table name while creating mv query.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata mv-2542

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2479.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2479
    
----
commit 844cff764e94f18ff8d115ccd636a06a0931bffb
Author: ravipesala <ra...@...>
Date:   2018-06-14T06:10:07Z

    Fixed order by in mv and aggregation functions inside projection expressions are fixed

commit 9a3ab54613a3cba1b77dcc951c87a817caa09252
Author: ravipesala <ra...@...>
Date:   2018-07-09T11:12:24Z

    Fix the mv query from table with different database

----


---

[GitHub] carbondata issue #2479: [CARBONDATA-2542][MV] Fix the mv query from table wi...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2479
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5966/



---

[GitHub] carbondata issue #2479: [CARBONDATA-2542][MV] Fix the mv query from table wi...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2479
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5749/



---

[GitHub] carbondata issue #2479: [CARBONDATA-2542][MV] Fix the mv query from table wi...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2479
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5855/



---

[GitHub] carbondata issue #2479: [CARBONDATA-2542][MV] Fix the mv query from table wi...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2479
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5764/



---

[GitHub] carbondata issue #2479: [CARBONDATA-2542][MV] Fix the mv query from table wi...

Posted by jackylk <gi...@git.apache.org>.

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2479
  
    The conflict is due to test case adding in #2476 
    I have resolved the conflict and merging this to master


---

[GitHub] carbondata issue #2479: [CARBONDATA-2542][MV] Fix the mv query from table wi...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2479
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7191/



---

[GitHub] carbondata issue #2479: [CARBONDATA-2542][MV] Fix the mv query from table wi...

Posted by jackylk <gi...@git.apache.org>.

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2479
  
    LGTM
    please rebase


---