[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #239: feat: add a calculation for `cpm5d`

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #239:
URL: https://github.com/apache/skywalking-booster-ui/pull/239#discussion_r1113174991


##########
src/hooks/useMetricsProcessor.ts:
##########
@@ -398,15 +398,15 @@ export function aggregation(val: number, config: { calculation?: string }): numb
     case Calculations.Apdex:
       data = (val / 10000).toFixed(2);
       break;
+    case Calculations.CPM5D:
+      data = (val / 100000).toFixed(2);

Review Comment:
   ```suggestion
         data = (val / 100000).toFixed(5);
   ```
   
   I think it is better to keep 5 digit? @@toffentoffen 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org