You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Newton Alex <na...@pivotal.io> on 2016/02/03 23:16:17 UTC

Review Request 43152: Pop up to confirm clean directories while adding HAWQ standby

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43152/
-----------------------------------------------------------

Review request for Ambari.


Bugs: AMBARI-14909
    https://issues.apache.org/jira/browse/AMBARI-14909


Repository: ambari


Description
-------

Pop up to confirm clean directories while adding HAWQ standby


Diffs
-----

  ambari-web/app/controllers/main/admin/highAvailability/hawq/addStandby/step3_controller.js 0cb256d 
  ambari-web/app/messages.js 8861b2a 

Diff: https://reviews.apache.org/r/43152/diff/


Testing
-------

Manual testing done.

Unit tests pass:
------
test loaded in: 0.00ms
Calling set on destroyed view
Calling set on destroyed view
Calling set on destroyed view
Calling set on destroyed view
Missing translation: admin.highAvailability.wizard.step2.header.title
Missing translation: admin.highAvailability.wizard.step2.notice.inProgress

  24140 tests complete (36 seconds)
  156 tests pending

[INFO] 
[INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
[INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 53.062s
[INFO] Finished at: Wed Feb 03 14:10:46 PST 2016
[INFO] Final Memory: 5M/81M
[INFO] ------------------------------------------------------------------------
nalex@office-5-146:~/Git/pivotal/ambari/ambari-web# 
--------------


Thanks,

Newton Alex


Re: Review Request 43152: Pop up to confirm clean directories while adding HAWQ standby

Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43152/#review117735
-----------------------------------------------------------


Ship it!




Ship It!

- Matt


On Feb. 3, 2016, 2:16 p.m., Newton Alex wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43152/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 2:16 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-14909
>     https://issues.apache.org/jira/browse/AMBARI-14909
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Pop up to confirm clean directories while adding HAWQ standby
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/highAvailability/hawq/addStandby/step3_controller.js 0cb256d 
>   ambari-web/app/messages.js 8861b2a 
> 
> Diff: https://reviews.apache.org/r/43152/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done.
> 
> Unit tests pass:
> ------
> test loaded in: 0.00ms
> Calling set on destroyed view
> Calling set on destroyed view
> Calling set on destroyed view
> Calling set on destroyed view
> Missing translation: admin.highAvailability.wizard.step2.header.title
> Missing translation: admin.highAvailability.wizard.step2.notice.inProgress
> 
>   24140 tests complete (36 seconds)
>   156 tests pending
> 
> [INFO] 
> [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-web ---
> [INFO] RAT will not execute since it is configured to be skipped via system property 'rat.skip'.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 53.062s
> [INFO] Finished at: Wed Feb 03 14:10:46 PST 2016
> [INFO] Final Memory: 5M/81M
> [INFO] ------------------------------------------------------------------------
> nalex@office-5-146:~/Git/pivotal/ambari/ambari-web# 
> --------------
> 
> 
> Thanks,
> 
> Newton Alex
> 
>