You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ptlrs (via GitHub)" <gi...@apache.org> on 2026/07/27 21:42:44 UTC

[PR] HDDS-16001. Add missing sections in pom.xml files to fix invalid testCompile configurations in IntelliJ. [ozone]

ptlrs opened a new pull request, #10880:
URL: https://github.com/apache/ozone/pull/10880

   ## What changes were proposed in this pull request?
   The run configurations in Intellij are invalid. This can be seen from the little red cross marks on the run configurations. The error says that the class in the run configuration doesn't exist in the class path.
   
   Since Intellij 2025.1 release, the way Intellij processes pom files has changed. It creates separate .main and .test modules in Maven projects.
   
   See https://youtrack.jetbrains.com/projects/IDEA/issues/IDEA-371535/Confusing-separate-.main-and-.test-modules-in-Maven-projects
   
   If there is a difference between the main and test configurations, then Intellij will create separate main and test modules. As such the default classpath won't work. The run configurations are pointing to classes which are not in the default classpath but instead in the classpath with the .main suffix. 
   
   This PR adds a `default-testCompile` for the test sections to bring them on par with the main configurations. After this Intellij doesn't split the module into `main` and `test` and the existing run configurations become valid again. 
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-16001
   
   
   ## How was this patch tested?
   Tested locally 
   CI: https://github.com/ptlrs/ozone/actions/runs/30307554649


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16001. Add missing sections in pom.xml files to fix invalid testCompile configurations in IntelliJ. [ozone]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10880:
URL: https://github.com/apache/ozone/pull/10880#issuecomment-5335787941

   This PR has been marked as stale due to 21 days of inactivity. Please comment or remove the stale label to keep it open. Otherwise, it will be automatically closed in 7 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16001. Add missing sections in pom.xml files to fix invalid testCompile configurations in IntelliJ. [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #10880:
URL: https://github.com/apache/ozone/pull/10880#discussion_r3663952876


##########
pom.xml:
##########
@@ -1841,6 +1841,17 @@
                 </compilerArgs>
               </configuration>
             </execution>
+            <execution>
+              <id>default-testCompile</id>
+              <goals>
+                <goal>testCompile</goal>
+              </goals>
+              <configuration>
+                <compilerArgs>
+                  <arg>-AartifactId=${project.artifactId}</arg>
+                </compilerArgs>
+              </configuration>
+            </execution>

Review Comment:
   These `testCompile` configurations cause warnings, please don't add them.  See HDDS-14789.
   
   ```
   [INFO] --- compiler:3.15.0:testCompile (default-testCompile) @ hdds-cli-common ---
   ...
   [WARNING] The following options were not recognized by any processor: '[project]'
   
   [INFO] --- compiler:3.15.0:testCompile (default-testCompile) @ hdds-client ---
   ...
   [WARNING] The following options were not recognized by any processor: '[artifactId]'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16001. Add missing sections in pom.xml files to fix invalid testCompile configurations in IntelliJ. [ozone]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10880:
URL: https://github.com/apache/ozone/pull/10880#issuecomment-5418706290

   Thank you for your contribution. This PR is being closed due to inactivity. Please contact a maintainer if you would like to reopen it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16001. Add missing sections in pom.xml files to fix invalid testCompile configurations in IntelliJ. [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #10880:
URL: https://github.com/apache/ozone/pull/10880#discussion_r3664513830


##########
.run/FreonStandalone.run.xml:
##########
@@ -17,7 +17,7 @@
 <component name="ProjectRunConfigurationManager">
   <configuration default="false" name="FreonStandalone" type="Application" factoryName="Application">
     <option name="MAIN_CLASS_NAME" value="org.apache.hadoop.ozone.freon.Freon" />
-    <module name="ozone-tools" />
+    <module name="ozone-freon" />

Review Comment:
   This is missing from #10881.



##########
.run/ScmRoles.run.xml:
##########
@@ -17,7 +17,7 @@
 <component name="ProjectRunConfigurationManager">
   <configuration default="false" name="ScmRoles" type="Application" factoryName="Application">
     <option name="MAIN_CLASS_NAME" value="org.apache.hadoop.ozone.admin.OzoneAdmin" />
-    <module name="ozone-tools" />
+    <module name="ozone-cli-admin" />

Review Comment:
   This is also included in #10881.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16001. Add missing sections in pom.xml files to fix invalid testCompile configurations in IntelliJ. [ozone]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #10880: HDDS-16001. Add missing sections in pom.xml files to fix invalid testCompile configurations in IntelliJ.
URL: https://github.com/apache/ozone/pull/10880


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org