You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "ji chen (Code Review)" <ge...@cloudera.org> on 2026/10/25 18:20:10 UTC
[Impala-ASF-CR] IMPALA-15623: [DOCS] Document Paimon Support
ji chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25209
Change subject: IMPALA-15623: [DOCS] Document Paimon Support
......................................................................
IMPALA-15623: [DOCS] Document Paimon Support
The topic described Paimon product features Impala does not implement,
including writes, time travel, and schema evolution, and it misstated
drop and type behavior. Describe the create, query, metadata, and drop
behavior that is implemented, and correct the Apache Paimon site link.
Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Assisted-by: Auto (Cursor)
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_paimon.xml
2 files changed, 245 insertions(+), 86 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/25209/1
--
To view, visit http://gerrit.cloudera.org:8080/25209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 1
Gerrit-Owner: ji chen <ji...@163.com>
[Impala-ASF-CR] IMPALA-15623: [DOCS] Document Paimon Support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25209 )
Change subject: IMPALA-15623: [DOCS] Document Paimon Support
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/959/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/25209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 1
Gerrit-Owner: ji chen <ji...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 Oct 2026 18:20:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15623: [DOCS] Document Paimon Support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25209 )
Change subject: IMPALA-15623: [DOCS] Document Paimon Support
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14326/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/25209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 2
Gerrit-Owner: ji chen <ji...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Oct 2026 23:29:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15623: [DOCS] Document Paimon Support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25209 )
Change subject: IMPALA-15623: [DOCS] Document Paimon Support
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14324/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/25209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 2
Gerrit-Owner: ji chen <ji...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Oct 2026 17:37:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15623: [DOCS] Document Paimon Support
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/25209 )
Change subject: IMPALA-15623: [DOCS] Document Paimon Support
......................................................................
Patch Set 1: Code-Review+1
(4 comments)
Thanks for the doc update!
I just left a few nits, otherwise LGTM
http://gerrit.cloudera.org:8080/#/c/25209/1/docs/topics/impala_paimon.xml
File docs/topics/impala_paimon.xml:
http://gerrit.cloudera.org:8080/#/c/25209/1/docs/topics/impala_paimon.xml@184
PS1, Line 184: Impala creates
: Parquet files
This text implies that Impala writes data files. We could say instead: "When the property is omitted, Impala does not set it and Paimon uses its default file format."
http://gerrit.cloudera.org:8080/#/c/25209/1/docs/topics/impala_paimon.xml@332
PS1, Line 332: <codeph>ARRAY</codeph>, <codeph>MAP</codeph>, and
: <codeph>STRUCT</codeph> columns cannot be read. Virtual columns such as
: <codeph>INPUT__FILE__NAME</codeph> are not available.
We could clarify that an existing table with such columns loads fine. You can query its other columns, and only reading the complex column fails. Since IMPALA-15054, EXPAND_COMPLEX_TYPES defaults to true, so SELECT * on such a table fails too. The workaround is to list the columns or run SET EXPAND_COMPLEX_TYPES=false.
http://gerrit.cloudera.org:8080/#/c/25209/1/docs/topics/impala_paimon.xml@337
PS1, Line 337: </concept>
Isn't SHOW FILES implemented for Paimon tables? It isn't mentioned anywhere, either as supported or as a limitation. I suggest adding it here and to the list at L60–85.
http://gerrit.cloudera.org:8080/#/c/25209/1/docs/topics/impala_paimon.xml@478
PS1, Line 478: is read as an Impala <codeph>TIMESTAMP</codeph>
AFAIK TIMESTAMP_LTZ values are converted to the query's local time zone, while a TIMESTAMP without a time zone is read as stored (UTC, no conversion). The text only says the value is "read as an Impala TIMESTAMP". Could you add the time-zone behavior?
--
To view, visit http://gerrit.cloudera.org:8080/25209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 1
Gerrit-Owner: ji chen <ji...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Oct 2026 13:50:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15623: [DOCS] Document Paimon Support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25209 )
Change subject: IMPALA-15623: [DOCS] Document Paimon Support
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/961/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/25209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 2
Gerrit-Owner: ji chen <ji...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Oct 2026 17:31:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15623: [DOCS] Document Paimon Support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25209 )
Change subject: IMPALA-15623: [DOCS] Document Paimon Support
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14320/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/25209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 1
Gerrit-Owner: ji chen <ji...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 Oct 2026 18:20:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15623: [DOCS] Document Paimon Support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25209 )
Change subject: IMPALA-15623: [DOCS] Document Paimon Support
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/25209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 2
Gerrit-Owner: ji chen <ji...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Oct 2026 04:05:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15623: [DOCS] Document Paimon Support
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25209 )
Change subject: IMPALA-15623: [DOCS] Document Paimon Support
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/959/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/25209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 1
Gerrit-Owner: ji chen <ji...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 25 Oct 2026 18:32:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15623: [DOCS] Document Paimon Support
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/25209 )
Change subject: IMPALA-15623: [DOCS] Document Paimon Support
......................................................................
IMPALA-15623: [DOCS] Document Paimon Support
The topic described Paimon product features Impala does not implement,
including writes, time travel, and schema evolution, and it misstated
drop and type behavior. Describe the create, query, metadata, and drop
behavior that is implemented, and correct the Apache Paimon site link.
Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Assisted-by: Auto (Cursor)
Reviewed-on: http://gerrit.cloudera.org:8080/25209
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Noemi Pap-Takacs <np...@cloudera.com>
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_paimon.xml
2 files changed, 263 insertions(+), 86 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Noemi Pap-Takacs: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/25209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 3
Gerrit-Owner: ji chen <ji...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
[Impala-ASF-CR] IMPALA-15623: [DOCS] Document Paimon Support
Posted by "ji chen (Code Review)" <ge...@cloudera.org>.
ji chen has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/25209 )
Change subject: IMPALA-15623: [DOCS] Document Paimon Support
......................................................................
IMPALA-15623: [DOCS] Document Paimon Support
The topic described Paimon product features Impala does not implement,
including writes, time travel, and schema evolution, and it misstated
drop and type behavior. Describe the create, query, metadata, and drop
behavior that is implemented, and correct the Apache Paimon site link.
Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Assisted-by: Auto (Cursor)
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_paimon.xml
2 files changed, 263 insertions(+), 86 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/25209/2
--
To view, visit http://gerrit.cloudera.org:8080/25209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 2
Gerrit-Owner: ji chen <ji...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
[Impala-ASF-CR] IMPALA-15623: [DOCS] Document Paimon Support
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/25209 )
Change subject: IMPALA-15623: [DOCS] Document Paimon Support
......................................................................
Patch Set 2: Code-Review+2
(4 comments)
Thanks! LGTM
http://gerrit.cloudera.org:8080/#/c/25209/1/docs/topics/impala_paimon.xml
File docs/topics/impala_paimon.xml:
http://gerrit.cloudera.org:8080/#/c/25209/1/docs/topics/impala_paimon.xml@184
PS1, Line 184: eph> or
: <codeph>orc</
> This text implies that Impala writes data files. We could say instead: "Whe
Done
http://gerrit.cloudera.org:8080/#/c/25209/1/docs/topics/impala_paimon.xml@332
PS1, Line 332: >
: An existing table that has <codeph>ARRAY</codeph>, <codeph>MAP</codeph>,
: or <codeph>STRUCT</codeph> columns still loads, and i
> We could clarify that an existing table with such columns loads fine. You c
Done
http://gerrit.cloudera.org:8080/#/c/25209/1/docs/topics/impala_paimon.xml@337
PS1, Line 337: <codeph>true</codeph>, so <codeph>SELECT *</codeph> expands those
> Isn't SHOW FILES implemented for Paimon tables? It isn't mentioned anywhere
Done
http://gerrit.cloudera.org:8080/#/c/25209/1/docs/topics/impala_paimon.xml@478
PS1, Line 478: >
> AFAIK TIMESTAMP_LTZ values are converted to the query's local time zone, wh
Done
--
To view, visit http://gerrit.cloudera.org:8080/25209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5593ab0e0b3bbd4955297ff4565d6316e2a38253
Gerrit-Change-Number: 25209
Gerrit-PatchSet: 2
Gerrit-Owner: ji chen <ji...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Oct 2026 13:21:32 +0000
Gerrit-HasComments: Yes