You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/07 03:21:28 UTC

[GitHub] [arrow] cyb70289 opened a new pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

cyb70289 opened a new pull request #10460:
URL: https://github.com/apache/arrow/pull/10460


   Install libarchive to fix cmake error on centos-8.
   
   cmake: undefined symbol: archive_write_add_filter_zstd


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] cyb70289 commented on a change in pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#discussion_r646326149



##########
File path: dev/tasks/linux-packages/apache-arrow/yum/centos-8/Dockerfile
##########
@@ -40,6 +40,7 @@ RUN \
     glog-devel \
     gobject-introspection-devel \
     gtk-doc \
+    libarchive \

Review comment:
       **UPDATE:** I'm wrong. Please ignore this message. Both `arm64v8/centos:8` and `centos:8` suffer from same cmake issue.
   
   ~~Some explanation:~~
   
   ~~`libarchive` is pre-installed in `arm64v8/centos:8`, but not in `centos:8`.~~
   ~~This dockerfile is based on `arm64v8/centos:8`, so it's okay.~~
   ~~`verify-yum.sh` is based on `centos:8` (multi arch image) and fails.~~
   
   ~~Will we unify x86 and arm to use `centos:8` only?~~




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] cyb70289 commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855716372


   No worry. It's trivial. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855565630


   @github-actions crossbow submit centos-8-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855647503


   The centos-8-arm64 failure is another problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#discussion_r646319581



##########
File path: dev/tasks/linux-packages/apache-arrow/yum/centos-8/Dockerfile
##########
@@ -40,6 +40,7 @@ RUN \
     glog-devel \
     gobject-introspection-devel \
     gtk-doc \
+    libarchive \

Review comment:
       Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855665234


   @github-actions crossbow submit centos-8-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#discussion_r646317538



##########
File path: dev/tasks/linux-packages/apache-arrow/yum/centos-8/Dockerfile
##########
@@ -40,6 +40,7 @@ RUN \
     glog-devel \
     gobject-introspection-devel \
     gtk-doc \
+    libarchive \

Review comment:
       We don't need this, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] cyb70289 commented on a change in pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#discussion_r646318955



##########
File path: dev/tasks/linux-packages/apache-arrow/yum/centos-8/Dockerfile
##########
@@ -40,6 +40,7 @@ RUN \
     glog-devel \
     gobject-introspection-devel \
     gtk-doc \
+    libarchive \

Review comment:
       Yes, will remove.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855729365


   Revision: fab45c86b483192baadae8d1d9f54c103146e720
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-476](https://github.com/ursacomputing/crossbow/branches/all?query=actions-476)
   
   |Task|Status|
   |----|------|
   |centos-8-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-476-github-centos-8-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-476-github-centos-8-amd64)|
   |centos-8-arm64|[![TravisCI](https://img.shields.io/travis/ursacomputing/crossbow/actions-476-travis-centos-8-arm64.svg)](https://travis-ci.com/ursacomputing/crossbow/branches)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] cyb70289 commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855665843


   I don't understand why x86 doesn't have this issue. Per my test with `centos:8` image, both x86 and Arm have this cmake undefined symbol error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855713740


   Oh, sorry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] cyb70289 commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855726461


   @github-actions crossbow submit centos-8-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] cyb70289 commented on a change in pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#discussion_r646326149



##########
File path: dev/tasks/linux-packages/apache-arrow/yum/centos-8/Dockerfile
##########
@@ -40,6 +40,7 @@ RUN \
     glog-devel \
     gobject-introspection-devel \
     gtk-doc \
+    libarchive \

Review comment:
       Some explanation:
   
   `libarchive` is pre-installed in `arm64v8/centos:8`, but not in `centos:8`.
   This dockerfile is based on `arm64v8/centos:8`, so it's okay.
   `verify-yum.sh` is based on `centos:8` (multi arch image) and fails.
   
   Will we unify x86 and arm to use `centos:8` only?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855608354


   Revision: fec33adce6b9696ebdd255ae18ce55ef7fa933a2
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-474](https://github.com/ursacomputing/crossbow/branches/all?query=actions-474)
   
   |Task|Status|
   |----|------|
   |centos-8-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-474-github-centos-8-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-474-github-centos-8-amd64)|
   |centos-8-arm64|[![TravisCI](https://img.shields.io/travis/ursacomputing/crossbow/actions-474-travis-centos-8-arm64.svg)](https://travis-ci.com/ursacomputing/crossbow/branches)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] cyb70289 commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855712592


   So `libarchive` is necessary in both places. Will add back.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] cyb70289 closed pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
cyb70289 closed pull request #10460:
URL: https://github.com/apache/arrow/pull/10460


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855665879


   Revision: f763ef02800bfa5e144107fc8b5ddd03e372294e
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-475](https://github.com/ursacomputing/crossbow/branches/all?query=actions-475)
   
   |Task|Status|
   |----|------|
   |centos-8-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-475-github-centos-8-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-475-github-centos-8-amd64)|
   |centos-8-arm64|[![TravisCI](https://img.shields.io/travis/ursacomputing/crossbow/actions-475-travis-centos-8-arm64.svg)](https://travis-ci.com/ursacomputing/crossbow/branches)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on a change in pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#discussion_r646319304



##########
File path: dev/tasks/linux-packages/apache-arrow/yum/centos-8/Dockerfile
##########
@@ -40,6 +40,7 @@ RUN \
     glog-devel \
     gobject-introspection-devel \
     gtk-doc \
+    libarchive \

Review comment:
       We don't need this, could you revert this before we merge this?

##########
File path: dev/tasks/linux-packages/apache-arrow/yum/centos-8/Dockerfile
##########
@@ -40,6 +40,7 @@ RUN \
     glog-devel \
     gobject-introspection-devel \
     gtk-doc \
+    libarchive \

Review comment:
       If we don't need this, could you revert this before we merge this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] cyb70289 commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855607893


   @github-actions crossbow submit centos-8-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855668278


   > I don't understand why x86 doesn't have this issue.
   
   This issue is "cmake: undefined symbol: archive_write_add_filter_zstd" not pygit2 error https://travis-ci.com/github/ursacomputing/crossbow/builds/228149814#L5782 , right?
   
   This issue happens on x86 without this fix: https://github.com/ursacomputing/crossbow/runs/2760533808?check_suite_focus=true#step:11:775


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855547032


   https://issues.apache.org/jira/browse/ARROW-12972


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] cyb70289 commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855547438


   @kou , anyway to trigger related crossbow build?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #10460: ARROW-12972: [CI] Fix centos-8 cmake error

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10460:
URL: https://github.com/apache/arrow/pull/10460#issuecomment-855565928


   Revision: 826f4a9cbea47a650a29a20a8891ede08f50b169
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-473](https://github.com/ursacomputing/crossbow/branches/all?query=actions-473)
   
   |Task|Status|
   |----|------|
   |centos-8-amd64|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-473-github-centos-8-amd64)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-473-github-centos-8-amd64)|
   |centos-8-arm64|[![TravisCI](https://img.shields.io/travis/ursacomputing/crossbow/actions-473-travis-centos-8-arm64.svg)](https://travis-ci.com/ursacomputing/crossbow/branches)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org