[GitHub] [iceberg] danielcweeks commented on pull request #4518: core: Provide mechanism to cache manifest file content

[GitBox <gi...@apache.org>]

danielcweeks commented on PR #4518:
URL: https://github.com/apache/iceberg/pull/4518#issuecomment-1176853748

   Hey @rizaon, some recent changes actually exposed FileIO properties, which I believe would simplify how we can cache manifest files.
   
   Where we [read manifest files](https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/ManifestFiles.java#L85), we now have the file legnth and properties from the FileIO.  It seems like we could just add a simple cache to the ManifestFiles and allow caching configuration via `FileIO::properties()`.
   
   I feel like that would really simplify this and avoid depending on things like regex+pathing to isolate which files to cache. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org