You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Mathias Herberts (JIRA)" <ji...@apache.org> on 2009/08/18 00:33:15 UTC

[jira] Created: (HBASE-1770) HTable.setWriteBufferSize does not flush the writeBuffer when its size is set to a value lower than its current size.

HTable.setWriteBufferSize does not flush the writeBuffer when its size is set to a value lower than its current size.
---------------------------------------------------------------------------------------------------------------------

                 Key: HBASE-1770
                 URL: https://issues.apache.org/jira/browse/HBASE-1770
             Project: Hadoop HBase
          Issue Type: Improvement
          Components: client
    Affects Versions: 0.20.0
         Environment: All
            Reporter: Mathias Herberts
            Priority: Trivial


When setting the size of the write buffer to a value lower than the current size of data in the write buffer, the content of the write buffer should be flushed so it does not occupy in memory more than its new size for an extended period of time.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HBASE-1770) HTable.setWriteBufferSize does not flush the writeBuffer when its size is set to a value lower than its current size.

Posted by "Mathias Herberts (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mathias Herberts updated HBASE-1770:
------------------------------------

    Attachment: setWriteBufferSize-flushCommits.patch

Adds call to flushCommits if the new size of the write buffer is lower than the current size of the data in the buffer.

Side effect is that setWriteBufferSize now throws IOException as propagated from flushCommits.

> HTable.setWriteBufferSize does not flush the writeBuffer when its size is set to a value lower than its current size.
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1770
>                 URL: https://issues.apache.org/jira/browse/HBASE-1770
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.20.0
>         Environment: All
>            Reporter: Mathias Herberts
>            Priority: Trivial
>         Attachments: setWriteBufferSize-flushCommits.patch
>
>
> When setting the size of the write buffer to a value lower than the current size of data in the write buffer, the content of the write buffer should be flushed so it does not occupy in memory more than its new size for an extended period of time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (HBASE-1770) HTable.setWriteBufferSize does not flush the writeBuffer when its size is set to a value lower than its current size.

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray resolved HBASE-1770.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
                   0.20.0
         Assignee: Mathias Herberts
     Hadoop Flags: [Reviewed]

Committed to trunk and branch.

Thanks for the patch, Mathias.

> HTable.setWriteBufferSize does not flush the writeBuffer when its size is set to a value lower than its current size.
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1770
>                 URL: https://issues.apache.org/jira/browse/HBASE-1770
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.20.0
>         Environment: All
>            Reporter: Mathias Herberts
>            Assignee: Mathias Herberts
>            Priority: Trivial
>             Fix For: 0.20.0, 0.21.0
>
>         Attachments: setWriteBufferSize-flushCommits.patch
>
>
> When setting the size of the write buffer to a value lower than the current size of data in the write buffer, the content of the write buffer should be flushed so it does not occupy in memory more than its new size for an extended period of time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-1770) HTable.setWriteBufferSize does not flush the writeBuffer when its size is set to a value lower than its current size.

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744267#action_12744267 ] 

stack commented on HBASE-1770:
------------------------------

+1 on adding to branch and trunk

> HTable.setWriteBufferSize does not flush the writeBuffer when its size is set to a value lower than its current size.
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1770
>                 URL: https://issues.apache.org/jira/browse/HBASE-1770
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.20.0
>         Environment: All
>            Reporter: Mathias Herberts
>            Priority: Trivial
>         Attachments: setWriteBufferSize-flushCommits.patch
>
>
> When setting the size of the write buffer to a value lower than the current size of data in the write buffer, the content of the write buffer should be flushed so it does not occupy in memory more than its new size for an extended period of time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-1770) HTable.setWriteBufferSize does not flush the writeBuffer when its size is set to a value lower than its current size.

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744255#action_12744255 ] 

Jonathan Gray commented on HBASE-1770:
--------------------------------------

Patch looks good.  Javadoc is a little bit odd because it seems like it's asking the client to call flushCommits rather than it happening automatically.  Can fix on commit.

Should we put this into 0.20 branch and trunk?

> HTable.setWriteBufferSize does not flush the writeBuffer when its size is set to a value lower than its current size.
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1770
>                 URL: https://issues.apache.org/jira/browse/HBASE-1770
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.20.0
>         Environment: All
>            Reporter: Mathias Herberts
>            Priority: Trivial
>         Attachments: setWriteBufferSize-flushCommits.patch
>
>
> When setting the size of the write buffer to a value lower than the current size of data in the write buffer, the content of the write buffer should be flushed so it does not occupy in memory more than its new size for an extended period of time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-1770) HTable.setWriteBufferSize does not flush the writeBuffer when its size is set to a value lower than its current size.

Posted by "Mathias Herberts (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744258#action_12744258 ] 

Mathias Herberts commented on HBASE-1770:
-----------------------------------------

Indeed my intent was to write 'calls flushCommits', not 'call flushCommits'.

> HTable.setWriteBufferSize does not flush the writeBuffer when its size is set to a value lower than its current size.
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1770
>                 URL: https://issues.apache.org/jira/browse/HBASE-1770
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.20.0
>         Environment: All
>            Reporter: Mathias Herberts
>            Priority: Trivial
>         Attachments: setWriteBufferSize-flushCommits.patch
>
>
> When setting the size of the write buffer to a value lower than the current size of data in the write buffer, the content of the write buffer should be flushed so it does not occupy in memory more than its new size for an extended period of time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.