[GitHub] [incubator-tvm] mwillsey commented on pull request #6779: [WIP] Object Schema

[GitBox <gi...@apache.org>]

mwillsey commented on pull request #6779:
URL: https://github.com/apache/incubator-tvm/pull/6779#issuecomment-720690753


   I could go either way on having the object schema in Python:
   + Pro: it's probably less verbose and it could also provide reasonable "defaults" and output very verbose JSON, rather than having each backend agree on how to interpret missing field of the JSON
   - Con: it's another build step, and ultimately writing a little bit of JSON one time isn't that bad. We could use something like YAML or TOML if we wanted to make it more user friendly
   
   I would like to echo @jroesch's concern that methods are a big part of this, as that what takes a lot of effort to get right. Also, I agree with folks above that checking-in generated code should be avoided if at all possible.
   
   If we go the route of just writing the schema by hand, we should consider not using strict JSON, as we will definitely want to support comments, trailing comma, etc in the schema.
   
   If we go python generated route, I agree with many of @tkonolige's comments above regarding simplicity. I think we should strive to keep the schema-generation code as slim as possible.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org