You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/13 08:15:08 UTC

[GitHub] [spark] maropu commented on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats

maropu commented on issue #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats
URL: https://github.com/apache/spark/pull/26016#issuecomment-565345548
 
 
   I looked over the code and I felt this change looks intrusive. For example, as another approach, we cannot just calculate actual table size by summing up UnsafeRow sizes partition-by-parition in `CommandUtils.calculateTotalSize` for analyze commands? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org