[GitHub] [pinot] snleee edited a comment on pull request #8074: For DISTINCT_COUNT, automatically convert Set to HyperLogLog when cardinality is too high

[GitBox <gi...@apache.org>]

snleee edited a comment on pull request #8074:
URL: https://github.com/apache/pinot/pull/8074#issuecomment-1022866328


   -1 on changing the default behavior. As @richardstartin mentioned, we should not change the default behavior because t the clients do expect the exact result when they run `distinctcount`.
   
   Meanwhile, if we keep the default behavior as it is, the user now needs to be educated enough to know how to configure hll threshold (`DISTINCTCOUNT(myCol, 'hllLog2m=8;hllConversionThreshold=10')`). Then, why not ask them to use `distinctcounthll` directly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org