[jira] [Commented] (TEZ-1131) Simplify EdgeManager APIs

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056502#comment-14056502 ] 

Bikas Saha commented on TEZ-1131:
---------------------------------

Review by Hitesh per offline discussion. Committed
commit 392727e1791078b82c6aa666a2206a279aa8813c
Author: Bikas Saha <bi...@apache.org>
Date:   Wed Jul 9 10:39:34 2014 -0700

    TEZ-1131 addendum for missing fix. Simplify EdgeManager APIs (bikas)


[~vikram.dixit] This will cause a build break for your custom edge. The fix is trivial as exemplified below. Use destinationFailedInputIndex wherever you used event.getIndex() in routeInputErrorEventToSource().
{code}
   @Override
   public int routeInputErrorEventToSource(InputReadErrorEvent event,
-      int destinationTaskIndex) {
-    return event.getIndex();
+      int destinationTaskIndex, int destinationFailedInputIndex) {
+    return destinationFailedInputIndex;
   }{code}

> Simplify EdgeManager APIs
> -------------------------
>
>                 Key: TEZ-1131
>                 URL: https://issues.apache.org/jira/browse/TEZ-1131
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>             Fix For: 0.5.0
>
>         Attachments: TEZ-1131.1.patch, TEZ-1131.2.patch, TEZ-1131.3.addendum.patch
>
>
> 2 pieces of feedback from [~daijy] 
> 1) Its not clear the event.sourceIndex needs to be accessed. Solution - Make it part of the method parameters
> 2) the Map<InputIndex, List<TaskIndex>> is convoluted. Solution - Replace with Map<TaskIndex, InputIndex>. Amazing why we did not do this in the first place.



--
This message was sent by Atlassian JIRA
(v6.2#6252)