You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by fe...@apache.org on 2022/05/31 08:48:08 UTC

[incubator-kyuubi] branch master updated: [KYUUBI #2717][FOLLOWUP] Fix BatchRestApiSuite due to jdbc state store UPPER the batch type

This is an automated email from the ASF dual-hosted git repository.

feiwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 80d45e42f [KYUUBI #2717][FOLLOWUP] Fix BatchRestApiSuite due to jdbc state store UPPER the batch type
80d45e42f is described below

commit 80d45e42fd4f109152cbdb7de4defb8f6408f59b
Author: Fei Wang <fw...@ebay.com>
AuthorDate: Tue May 31 16:48:01 2022 +0800

    [KYUUBI #2717][FOLLOWUP] Fix BatchRestApiSuite due to jdbc state store UPPER the batch type
    
    ### _Why are the changes needed?_
    
    Because I did not rebase for pr #2717, so the UT is impacted because  jdbc state store UPPER the batch type when persisting to state store.
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #2792 from turboFei/KYUUBI_2717_followup.
    
    Closes #2717
    
    d0365aaca [Fei Wang] [KYUUBI #2717][FOLLOWUP] Fix BatchRestApiSuite due to jdbc state store UPPER the batch type
    04920c624 [Fei Wang] [KYUUBI #2717][FOLLOWUP] Fix BatchRestApiSuite due to jdbc state store UPPER the batch type
    
    Authored-by: Fei Wang <fw...@ebay.com>
    Signed-off-by: Fei Wang <fw...@ebay.com>
---
 .../org/apache/kyuubi/server/rest/client/BatchRestApiSuite.scala    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/rest/client/BatchRestApiSuite.scala b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/rest/client/BatchRestApiSuite.scala
index 7e66df23c..49dd4369e 100644
--- a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/rest/client/BatchRestApiSuite.scala
+++ b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/rest/client/BatchRestApiSuite.scala
@@ -62,7 +62,7 @@ class BatchRestApiSuite extends RestClientTestHelper {
     assert(batch.getBatchType === "SPARK")
 
     // get batch log
-    var log = batchRestApi.getBatchLocalLog(batch.getId(), 0, 1)
+    val log = batchRestApi.getBatchLocalLog(batch.getId(), 0, 1)
     assert(log.getRowCount == 1)
 
     // delete batch
@@ -118,10 +118,10 @@ class BatchRestApiSuite extends RestClientTestHelper {
     // get batch by id
     batch = batchRestApi.getBatchById(batch.getId())
     assert(batch.getKyuubiInstance === fe.connectionUrl)
-    assert(batch.getBatchType === "spark")
+    assert(batch.getBatchType === "SPARK")
 
     // get batch log
-    var log = batchRestApi.getBatchLocalLog(batch.getId(), 0, 1)
+    val log = batchRestApi.getBatchLocalLog(batch.getId(), 0, 1)
     assert(log.getRowCount == 1)
 
     // delete batch