You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/18 20:45:14 UTC

[GitHub] [beam] egalpin commented on a diff in pull request #22216: BEAM-13592 Add getOrderingKey in o.a.b.sdk.io.gcp.pubsub.PubsubMessage

egalpin commented on code in PR #22216:
URL: https://github.com/apache/beam/pull/22216#discussion_r923845424


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubMessages.java:
##########
@@ -45,7 +45,10 @@ public static com.google.pubsub.v1.PubsubMessage toProto(PubsubMessage input) {
 
   public static PubsubMessage fromProto(com.google.pubsub.v1.PubsubMessage input) {

Review Comment:
   Does the corresponding `toProto` method also need to be updated to support `orderingKey`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org