You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/07 09:39:21 UTC
[GitHub] [arrow] nevi-me opened a new pull request #9650: ARROW-11898: [Rust] Pretty print columns
nevi-me opened a new pull request #9650:
URL: https://github.com/apache/arrow/pull/9650
Adds a way to also pretty-print a slice of columns, as a convenience to aviod creating a single-column record batch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on a change in pull request #9650: ARROW-11898: [Rust] Pretty print columns
Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #9650:
URL: https://github.com/apache/arrow/pull/9650#discussion_r589002450
##########
File path: .github/workflows/rust.yml
##########
@@ -110,7 +110,7 @@ jobs:
export CARGO_TARGET_DIR="/github/home/target"
cd rust
# run tests on all workspace members with default feature list
- cargo test
+ # cargo test
Review comment:
I'm piggybacking off this PR to try find the cause for the CI hang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9650: ARROW-11898: [Rust] Pretty print columns
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9650:
URL: https://github.com/apache/arrow/pull/9650#issuecomment-792325008
FYI I merged https://github.com/apache/arrow/pull/9653 / [ARROW-11896](https://issues.apache.org/jira/browse/ARROW-11896) for the Rust CI checks which may affect this PR. If you see "Rust / AMD64 Debian 10 Rust stable test workspace" failing with a linker error or no logs, rebasing against master will hopefully fix the problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9650: ARROW-11898: [Rust] Pretty print columns
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9650:
URL: https://github.com/apache/arrow/pull/9650#issuecomment-792249718
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9650?src=pr&el=h1) Report
> Merging [#9650](https://codecov.io/gh/apache/arrow/pull/9650?src=pr&el=desc) (e5c8fe5) into [master](https://codecov.io/gh/apache/arrow/commit/dec5ab9677a0dfb9e324a57ccf5550217a2117be?el=desc) (dec5ab9) will **decrease** coverage by `0.01%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/arrow/pull/9650?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9650 +/- ##
==========================================
- Coverage 82.51% 82.50% -0.02%
==========================================
Files 245 245
Lines 57329 57378 +49
==========================================
+ Hits 47306 47338 +32
- Misses 10023 10040 +17
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9650?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/array\_list.rs](https://codecov.io/gh/apache/arrow/pull/9650/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfbGlzdC5ycw==) | `92.88% <ø> (-0.07%)` | :arrow_down: |
| [rust/arrow/src/datatypes/native.rs](https://codecov.io/gh/apache/arrow/pull/9650/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZGF0YXR5cGVzL25hdGl2ZS5ycw==) | `76.59% <22.22%> (-12.88%)` | :arrow_down: |
| [rust/arrow/src/util/pretty.rs](https://codecov.io/gh/apache/arrow/pull/9650/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvdXRpbC9wcmV0dHkucnM=) | `94.77% <87.09%> (-2.32%)` | :arrow_down: |
| [rust/arrow/src/array/array\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9650/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfYmluYXJ5LnJz) | `91.82% <100.00%> (ø)` | |
| [rust/arrow/src/array/array\_primitive.rs](https://codecov.io/gh/apache/arrow/pull/9650/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfcHJpbWl0aXZlLnJz) | `95.00% <100.00%> (+0.04%)` | :arrow_up: |
| [rust/arrow/src/array/array\_string.rs](https://codecov.io/gh/apache/arrow/pull/9650/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvYXJyYXlfc3RyaW5nLnJz) | `96.06% <100.00%> (ø)` | |
| [rust/datafusion/src/physical\_plan/merge.rs](https://codecov.io/gh/apache/arrow/pull/9650/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL21lcmdlLnJz) | `76.56% <100.00%> (ø)` | |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9650/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.05% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9650?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9650?src=pr&el=footer). Last update [2585f7c...e5c8fe5](https://codecov.io/gh/apache/arrow/pull/9650?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9650: ARROW-11898: [Rust] Pretty print columns
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9650:
URL: https://github.com/apache/arrow/pull/9650#issuecomment-792330634
> FYI I merged #9653 / [ARROW-11896](https://issues.apache.org/jira/browse/ARROW-11896) for the Rust CI checks which may affect this PR. If you see "Rust / AMD64 Debian 10 Rust stable test workspace" failing with a linker error or no logs, rebasing against master will hopefully fix the problem
Thakns, I'm rebasing my PRs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9650: ARROW-11898: [Rust] Pretty print columns
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9650:
URL: https://github.com/apache/arrow/pull/9650#issuecomment-792246946
https://issues.apache.org/jira/browse/ARROW-11898
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9650: ARROW-11898: [Rust] Pretty print columns
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9650:
URL: https://github.com/apache/arrow/pull/9650
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org