[GitHub] [beam] ibzib commented on a change in pull request #13740: [BEAM-11626] Guava version 25.1-jre for Hadoop/Cassandra and Guava version 30.1 (latest) for the rest

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #13740:
URL: https://github.com/apache/beam/pull/13740#discussion_r562975904



##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -436,7 +444,7 @@ class BeamModulePlugin implements Plugin<Project> {
     def google_oauth_clients_version = "1.31.0"
     // Try to keep grpc_version consistent with gRPC version in google_cloud_platform_libraries_bom
     def grpc_version = "1.32.2"
-    def guava_version = "25.1-jre"
+    def guava_version = guava25Projects.contains(project.path) ? "25.1-jre" : "30.1-jre"

Review comment:
       We always treat library.java as a global constant. In all existing cases where a project requires a library version that deviates from library.java, we don't use library.java and instead hard-code that dependency in the project's build.gradle. 
   
   IMO making library.java conditional on the project being compiled defeats the purpose of declaring a common version in the first place.
   

##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -83,6 +83,14 @@ class BeamModulePlugin implements Plugin<Project> {
 """
   static AtomicInteger startingExpansionPortNumber = new AtomicInteger(18091)
 
+  /** List of paths to the projects that require Guava 25. Hadoop and Cassandra have dependency to
+   * methods available in the old Guava version (BEAM-11626) */
+  static List<String> guava25Projects = [
+    ":sdks:java:io:cassandra",
+    ":sdks:java:io:hadoop-format",

Review comment:
       What about `hadoop-common` and `hadoop-input-format`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org