[GitHub] [incubator-druid] leventov commented on a change in pull request #8990: Fix double-checked locking in predicate for SelectorDimFilter

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #8990: Fix double-checked locking in predicate for SelectorDimFilter
URL: https://github.com/apache/incubator-druid/pull/8990#discussion_r354935761
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/filter/SelectorDimFilter.java
 ##########
 @@ -71,7 +73,9 @@ public SelectorDimFilter(
   )
   {
     Preconditions.checkArgument(dimension != null, "dimension must not be null");
-
+    this.longPredicate = makeLongPredicateSupplier().get();
 
 Review comment:
   The semantic is changed: now predicates are not lazy. Here, you cannot use memoize() as in other classes - you should more scrupulously follow the "golden" examples forged in #6662.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org