You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by exabrial <gi...@git.apache.org> on 2016/04/28 18:20:36 UTC
[GitHub] activemq-artemis pull request: Fix Issue #245
GitHub user exabrial opened a pull request:
https://github.com/apache/activemq-artemis/pull/496
Fix Issue #245
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/exabrial/activemq-artemis issue_245
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/496.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #496
----
commit 6db68768685686b73aebba5539ab80f3cc77d4af
Author: Jonathan S. Fisher <ex...@gmail.com>
Date: 2016-04-28T16:20:08Z
Fix Issue #245
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix Issue #245
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/496#issuecomment-220307610
@exabrial I'd be happy to help. I can talk to you on IRC #activemq or on the dev list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix Issue #245
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/496#issuecomment-220353546
@exabrial I am going to close this PR based on our discussion. We can reopen later if need be.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix Issue #245
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/496#issuecomment-220354749
@exabrial Actually doesn't look like I have permissions to close this PR. Could you please close it.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix Issue #245
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/496#issuecomment-220273790
@exabrial Hi, any chance you could update the commit message and we'll get this merged.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix Issue #245
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/496#issuecomment-216525069
@exabrial Hi could you please add a bit more context to the commit message.
@clebertsuconic I will leave this one with you since you have been involved in #245.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix Issue #245
Posted by exabrial <gi...@git.apache.org>.
Github user exabrial closed the pull request at:
https://github.com/apache/activemq-artemis/pull/496
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix Issue #245
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/496#issuecomment-216553610
The commit message should be something like:
ARTEMIS-### Any textual explaining what's being done...
We don't simply rely on the Links from JIRA for instance... the jira might be replaced some day.. and when someone is looking from git logs.. it gets impracticable to look for changes and looking for regressions if we only used jira links.
If you can't do it I will treat this as a patch and rebase during merge... but you would probably lose ownership of your commit on the logs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: Fix Issue #245
Posted by exabrial <gi...@git.apache.org>.
Github user exabrial commented on the pull request:
https://github.com/apache/activemq-artemis/pull/496#issuecomment-220302866
I'm not completely sure it's correct actually... a better way would be go
make the connection class an interface, rather than a final class.
Also at Devoxx UK in two weeks I'm leading a workshop with the goal is to
get this working 100%. If any of you will be available, or present
physically, that'd be awesome!
On May 19, 2016 5:30 AM, "Martyn Taylor" <no...@github.com> wrote:
> @exabrial <https://github.com/exabrial> Hi, any chance you could update
> the commit message and we'll get this merged.
>
> Thanks
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/activemq-artemis/pull/496#issuecomment-220273790>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---