You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Rainer Jung <ra...@kippdata.de> on 2018/05/09 08:26:36 UTC

Re: svn commit: r1830392 - in /tomcat/tc8.5.x/tags/TOMCAT_8_5_31: ./ build.properties.default webapps/docs/changelog.xml

Am 27.04.2018 um 21:57 schrieb markt@apache.org:
> Author: markt
> Date: Fri Apr 27 19:57:27 2018
> New Revision: 1830392
> 
> URL: http://svn.apache.org/viewvc?rev=1830392&view=rev
> Log:
> Tag 8.5.31
> 
...

> Modified: tomcat/tc8.5.x/tags/TOMCAT_8_5_31/webapps/docs/changelog.xml
> URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/tags/TOMCAT_8_5_31/webapps/docs/changelog.xml?rev=1830392&r1=1830391&r2=1830392&view=diff
> ==============================================================================
> --- tomcat/tc8.5.x/tags/TOMCAT_8_5_31/webapps/docs/changelog.xml (original)
> +++ tomcat/tc8.5.x/tags/TOMCAT_8_5_31/webapps/docs/changelog.xml Fri Apr 27 19:57:27 2018
> @@ -1,4 +1,4 @@
> -<?xml version="1.0" encoding="UTF-8"?>
> +<?xml version="1.0" encoding="UTF-8"?>
>   <!--
>     Licensed to the Apache Software Foundation (ASF) under one or more
>     contributor license agreements.  See the NOTICE file distributed with

This chunk introduced 3 bytes in front of the XML declaration, maybe a 
BOM or similar (although the bytes are ef bb bf).

When trying to build 8.5.31 from the unix tarball including validation, 
checkstyle complained with:

webapps/docs/changelog.xml:1: Line does not match expected header line 
of '^(rem)?\W*Licensed to the Apache Software Foundation \(ASF\) under 
one or more$'. [RegexpHeader]

Thus the build failed.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1830392 - in /tomcat/tc8.5.x/tags/TOMCAT_8_5_31: ./ build.properties.default webapps/docs/changelog.xml

Posted by Mark Thomas <ma...@apache.org>.
On 09/05/18 09:26, Rainer Jung wrote:
> Am 27.04.2018 um 21:57 schrieb markt@apache.org:
>> Author: markt
>> Date: Fri Apr 27 19:57:27 2018
>> New Revision: 1830392
>>
>> URL: http://svn.apache.org/viewvc?rev=1830392&view=rev
>> Log:
>> Tag 8.5.31
>>
> ...
> 
>> Modified: tomcat/tc8.5.x/tags/TOMCAT_8_5_31/webapps/docs/changelog.xml
>> URL:
>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/tags/TOMCAT_8_5_31/webapps/docs/changelog.xml?rev=1830392&r1=1830391&r2=1830392&view=diff
>>
>> ==============================================================================
>>
>> --- tomcat/tc8.5.x/tags/TOMCAT_8_5_31/webapps/docs/changelog.xml
>> (original)
>> +++ tomcat/tc8.5.x/tags/TOMCAT_8_5_31/webapps/docs/changelog.xml Fri
>> Apr 27 19:57:27 2018
>> @@ -1,4 +1,4 @@
>> -<?xml version="1.0" encoding="UTF-8"?>
>> +<?xml version="1.0" encoding="UTF-8"?>
>>   <!--
>>     Licensed to the Apache Software Foundation (ASF) under one or more
>>     contributor license agreements.  See the NOTICE file distributed with
> 
> This chunk introduced 3 bytes in front of the XML declaration, maybe a
> BOM or similar (although the bytes are ef bb bf).
> 
> When trying to build 8.5.31 from the unix tarball including validation,
> checkstyle complained with:
> 
> webapps/docs/changelog.xml:1: Line does not match expected header line
> of '^(rem)?\W*Licensed to the Apache Software Foundation \(ASF\) under
> one or more$'. [RegexpHeader]
> 
> Thus the build failed.

How very annoying.

I would have edited that on Windows. I wonder why it happened this time
and not any other? Maybe I used a different editor. I'll keep an eye on
it for next time.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org