[jira] [Commented] (NIFI-534) Missing data points in Cluster Status History

["Mark Payne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509211#comment-14509211 ] 

Mark Payne commented on NIFI-534:
---------------------------------

Matt,

Looks good. Only change I'd suggest is when you catch Throwable and log:
                    logger.warn("Unable to capture component metrics from Node heartbeats: " + t);

Please ensure that if logger.isDebugEnabled that we log stack trace:
                    logger.warn("Unable to capture component metrics from Node heartbeats: " + t);
                    if (logger.isDebugEnabled()) {
                        logger.warn("", t);
                    }

Otherwise +1

-Mark

> Missing data points in Cluster Status History
> ---------------------------------------------
>
>                 Key: NIFI-534
>                 URL: https://issues.apache.org/jira/browse/NIFI-534
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Matt Gilman
>            Assignee: Matt Gilman
>            Priority: Minor
>             Fix For: 0.1.0
>
>         Attachments: 0001-NIFI-534.patch
>
>
> Ensure at least one data point is captured during each window. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)