You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mxnet.apache.org by bartekkuncer <no...@github.com.INVALID> on 2021/02/23 13:12:07 UTC

[apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

From https://github.com/apache/incubator-mxnet/issues/19610:

&gt; Intel MKL-DNN was renamed with DNNL in its v1.1 release. Since then, the MXNet community has been working on the transition to DNNL to leverage the latest features and optimizations from the library. That includes using the string “DNNL” or “dnnl” for future development and communication. We propose to promote the flag “USE_DNNL” since MXNet 2.0 and start deprecating “USE_MKLDNN” at the same time.
&gt; DNNL source code resides in the 3rdparty/mkldnn folder of the MXNet repository and is released and distributed along with MXNet source code. If one wants to build MXNet with DNNL to accelerate the execution on Intel CPU, she/he needs to enable -DUSE_DNNL=ON in CMake. However, this flag has been set to ON by default for all platforms except edge devices. On the contrary, to disable the DNNL acceleration, one needs to set -DUSE_DNNL=OFF explicitly in the CMake command line or the CMake configuration file.
&gt; As both MXNet and DNNL are under quick development with different release cadence, we decide to link the DNNL library into MXNet statically to avoid mis-linking in the user&#39;s environment. Given this, we need to set DNNL_LIBRARY_TYPE to STATIC when building DNNL.
&gt; Some additional flags to build DNNL:
&gt; 
&gt; DNNl_CPU_RUNTIME: Need set it to SEQ explicitly when USE_OPENMP=OFF;
&gt; DNNL_ARCH_OPT_FLAGS: Need pass compiler options to this build flag in string. Eg. -march or -mtune for GCC.
&gt; MKLDNN_BUILD_TESTS and MKLDNN_BUILD_EXAMPLES: We set these two flags to OFF to speed up the compilation.
&gt; One thing that needs to be taken care of is that the header dnnl_config.h and dnnl_version.h will be generated dynamically during compilation and will be copied to the installation destination when calling make install. That means these two headers are not distributed with DNNL source code. For downstream projects which are including these headers need to find them in the installation path rather than the source code path.

I prepared two commits regarding this point of main RFC:
1. changing USE_MKLDNN flag name to USE_ONEDNN to make it consistent with actual library name
I believe that this commit is complete and if there is such a will can be merged into master.

2. changing MXNET_USE_MKLDNN* flags names to MXNET_USE_ONEDNN* also for consistency reasons
This commit regards changing inner MXNET flag so that it will be consistent with the actual lib name. To avoid creating even bigger mixture of mkldnn/dnnl/onednn acronyms I believe it should be accompanied with another commit changing acronyms used in mxnet function names and comments regarding this particular lib to oneDNN. What do you think about it?

There is also another idea to change the 3rdparty/mkldnn folder name to 3rdparty/onednn for consistency. The problem is that it will create unnecessary difference in directories names between branches.
You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-mxnet/pull/19944

-- Commit Summary --

  * Change flag MXNET_USE_MKLDNN to MXNET_USE_ONEDNN
  * Change USE_MKLDNN flag to USE_ONEDNN

-- File Changes --

    M CMakeLists.txt (14)
    M ci/build_windows.py (8)
    M ci/docker/runtime_functions.sh (42)
    M config/darwin.cmake (2)
    M config/distribution/darwin_cpu.cmake (2)
    M config/distribution/darwin_native.cmake (2)
    M config/distribution/linux_cpu.cmake (2)
    M config/distribution/linux_cu100.cmake (2)
    M config/distribution/linux_cu101.cmake (2)
    M config/distribution/linux_cu102.cmake (2)
    M config/distribution/linux_cu110.cmake (2)
    M config/distribution/linux_cu92.cmake (2)
    M config/distribution/linux_native.cmake (2)
    M config/linux.cmake (2)
    M config/linux_gpu.cmake (2)
    M docs/python_docs/python/tutorials/performance/backend/mkldnn/mkldnn_readme.md (16)
    M docs/static_site/src/pages/api/faq/env_var.md (4)
    M docs/static_site/src/pages/api/faq/perf.md (2)
    M example/multi_threaded_inference/Makefile (2)
    M include/mxnet/base.h (2)
    M include/mxnet/libinfo.h (4)
    M include/mxnet/ndarray.h (14)
    M src/c_api/c_api.cc (8)
    M src/common/exec_utils.h (8)
    M src/common/utils.h (4)
    M src/imperative/attach_op_execs_pass.cc (2)
    M src/imperative/imperative_utils.h (8)
    M src/libinfo.cc (2)
    M src/ndarray/ndarray.cc (22)
    M src/operator/contrib/batch_norm_relu.cc (12)
    M src/operator/leaky_relu.cc (16)
    M src/operator/nn/activation.cc (18)
    M src/operator/nn/batch_norm.cc (12)
    M src/operator/nn/concat.cc (50)
    M src/operator/nn/convolution.cc (16)
    M src/operator/nn/deconvolution.cc (10)
    M src/operator/nn/fully_connected.cc (12)
    M src/operator/nn/log_softmax.cc (8)
    M src/operator/nn/lrn.cc (12)
    M src/operator/nn/mkldnn/mkldnn_act-inl.h (4)
    M src/operator/nn/mkldnn/mkldnn_act.cc (2)
    M src/operator/nn/mkldnn/mkldnn_base-inl.h (2)
    M src/operator/nn/mkldnn/mkldnn_base.cc (4)
    M src/operator/nn/mkldnn/mkldnn_batch_norm-inl.h (4)
    M src/operator/nn/mkldnn/mkldnn_concat-inl.h (4)
    M src/operator/nn/mkldnn/mkldnn_concat.cc (4)
    M src/operator/nn/mkldnn/mkldnn_convolution-inl.h (4)
    M src/operator/nn/mkldnn/mkldnn_convolution.cc (4)
    M src/operator/nn/mkldnn/mkldnn_copy.cc (2)
    M src/operator/nn/mkldnn/mkldnn_deconvolution.cc (4)
    M src/operator/nn/mkldnn/mkldnn_fully_connected-inl.h (4)
    M src/operator/nn/mkldnn/mkldnn_fully_connected.cc (4)
    M src/operator/nn/mkldnn/mkldnn_log_softmax.cc (2)
    M src/operator/nn/mkldnn/mkldnn_lrn-inl.h (4)
    M src/operator/nn/mkldnn/mkldnn_ops-inl.h (4)
    M src/operator/nn/mkldnn/mkldnn_pooling-inl.h (4)
    M src/operator/nn/mkldnn/mkldnn_pooling.cc (4)
    M src/operator/nn/mkldnn/mkldnn_reshape-inl.h (4)
    M src/operator/nn/mkldnn/mkldnn_reshape.cc (2)
    M src/operator/nn/mkldnn/mkldnn_rnn-inl.h (6)
    M src/operator/nn/mkldnn/mkldnn_rnn.cc (4)
    M src/operator/nn/mkldnn/mkldnn_slice-inl.h (4)
    M src/operator/nn/mkldnn/mkldnn_slice.cc (4)
    M src/operator/nn/mkldnn/mkldnn_softmax.cc (2)
    M src/operator/nn/mkldnn/mkldnn_sum.cc (2)
    M src/operator/nn/mkldnn/mkldnn_transpose.cc (2)
    M src/operator/nn/pooling.cc (32)
    M src/operator/nn/softmax.cc (8)
    M src/operator/operator_common.h (6)
    M src/operator/quantization/dequantize.cc (8)
    M src/operator/quantization/mkldnn/mkldnn_dequantize-inl.h (4)
    M src/operator/quantization/mkldnn/mkldnn_quantize-inl.h (4)
    M src/operator/quantization/mkldnn/mkldnn_quantize_v2-inl.h (4)
    M src/operator/quantization/mkldnn/mkldnn_quantized_act.cc (4)
    M src/operator/quantization/mkldnn/mkldnn_quantized_batch_norm.cc (4)
    M src/operator/quantization/mkldnn/mkldnn_quantized_concat.cc (4)
    M src/operator/quantization/mkldnn/mkldnn_quantized_conv.cc (4)
    M src/operator/quantization/mkldnn/mkldnn_quantized_elemwise_add.cc (4)
    M src/operator/quantization/mkldnn/mkldnn_quantized_flatten.cc (4)
    M src/operator/quantization/mkldnn/mkldnn_quantized_fully_connected.cc (4)
    M src/operator/quantization/mkldnn/mkldnn_quantized_ops-inl.h (4)
    M src/operator/quantization/mkldnn/mkldnn_quantized_pooling.cc (4)
    M src/operator/quantization/mkldnn/mkldnn_requantize-inl.h (4)
    M src/operator/quantization/quantize.cc (6)
    M src/operator/quantization/quantize_v2.cc (8)
    M src/operator/quantization/quantized_activation.cc (2)
    M src/operator/quantization/quantized_batch_norm.cc (4)
    M src/operator/quantization/quantized_conv.cc (12)
    M src/operator/quantization/quantized_fully_connected.cc (10)
    M src/operator/quantization/quantized_pooling.cc (8)
    M src/operator/quantization/requantize.cc (6)
    M src/operator/rnn.cc (24)
    M src/operator/subgraph/mkldnn/mkldnn_bn_relu_property.h (4)
    M src/operator/subgraph/mkldnn/mkldnn_common.h (4)
    M src/operator/subgraph/mkldnn/mkldnn_conv-inl.h (4)
    M src/operator/subgraph/mkldnn/mkldnn_conv.cc (4)
    M src/operator/subgraph/mkldnn/mkldnn_conv_property.h (4)
    M src/operator/subgraph/mkldnn/mkldnn_elemwisemul_post_quantize_property.h (4)
    M src/operator/subgraph/mkldnn/mkldnn_fc-inl.h (4)
    M src/operator/subgraph/mkldnn/mkldnn_fc.cc (4)
    M src/operator/subgraph/mkldnn/mkldnn_fc_post_quantize_property.h (4)
    M src/operator/subgraph/mkldnn/mkldnn_fc_property.h (4)
    M src/operator/subgraph/mkldnn/mkldnn_post_quantize_align_scale_property.h (4)
    M src/operator/subgraph/mkldnn/mkldnn_post_quantize_property.h (4)
    M src/operator/subgraph/mkldnn/mkldnn_subgraph_base-inl.h (4)
    M src/operator/subgraph/mkldnn/mkldnn_subgraph_property.cc (4)
    M src/operator/subgraph/partitioner/custom_subgraph_property.h (4)
    M src/operator/tensor/amp_cast.cc (12)
    M src/operator/tensor/cast_storage-inl.h (6)
    M src/operator/tensor/elemwise_binary_op_basic.cc (12)
    M src/operator/tensor/elemwise_sum.cc (8)
    M src/operator/tensor/elemwise_unary_op.h (2)
    M src/operator/tensor/elemwise_unary_op_basic.cc (16)
    M src/operator/tensor/matrix_op-inl.h (2)
    M src/operator/tensor/matrix_op.cc (22)
    M src/serialization/cnpy.cc (4)
    M src/storage/cpu_device_storage.h (2)
    M src/storage/storage_manager_helpers.h (2)
    M tests/README.md (4)
    M tests/cpp/include/test_mkldnn.h (4)
    M tests/cpp/include/test_util.h (2)
    M tests/cpp/operator/batchnorm_test.cc (4)
    M tests/cpp/operator/mkldnn_operator_test.cc (4)
    M tests/cpp/operator/mkldnn_test.cc (4)
    M tests/cpp/storage/storage_test.cc (2)

-- Patch Links --

https://github.com/apache/incubator-mxnet/pull/19944.patch
https://github.com/apache/incubator-mxnet/pull/19944.diff

-- 
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

be72ba1985aa07118e00dc22c4170191eead4675  Change inner mxnet flags nomenclature for oneDNN library


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/cf40e6528f381c5e63bd13d9c3f60845a42e61df..be72ba1985aa07118e00dc22c4170191eead4675

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer commented on this pull request.



> @@ -62,18 +62,18 @@ To achieve better performance, the Intel OpenMP and llvm OpenMP are recommended
 ```

Changed the names, but left the file name. I believe it should be changed later if the file nomenclature will change from mkldnn to onednn in whole project.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#discussion_r588400970

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Tao Lv <no...@github.com.INVALID>.
Will this cause any incompatible issue for downstream projects? I'm not sure if there is any using the master branch and the alpha release is already in process.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-786451703

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Sam Skalicky <no...@github.com.INVALID>.
> I think that the commits regarding updating onednns old acronyms used in mxnet in different contexts can be added to separate PR and if there is no objection this one can be already merged into master to avoid creating code with deprecated versions of the flags.

Can you give an example, which acronyms are you referring to?

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-785242710

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
> It complains that the commit is not mergeable: https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fsanity/detail/PR-19944/15/pipeline#log-42
> 
> @bartekkuncer would you mind doing a rebase to the latest master branch and do a force push?

@szha Sure, thanks for help. It is quite strange that the merging worked for all other checks.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-790408927

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

a5ad2239c8974b1e8c49e73aeee9ea75891da71c  Change MKLDNN to ONEDNN in comments surrounding changed flags


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/4f43d96c8e7e5d832ce25957936b02138b8da1ad..a5ad2239c8974b1e8c49e73aeee9ea75891da71c

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
Fixed merge conflicts.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-788883188

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
> > There is also another idea to change the 3rdparty/mkldnn folder name to 3rdparty/onednn for consistency. The problem is that it will create unnecessary difference in directories names between branches.
> 
> since this is the master branch, and we're moving from 1.x to 2.0 shouldnt this be the time to make this change? Having a directory named "mkldnn" but using "onednn" everywhere will only cause confusion in the future for those who do not have the historical background.

Ok, will add it soon.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-784979174

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Sheng Zha <no...@github.com.INVALID>.
It complains that the commit is not mergeable: https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fsanity/detail/PR-19944/15/pipeline#log-42

@bartekkuncer would you mind doing a rebase to the latest master branch and do a force push?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789829072

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
> > I think that the commits regarding updating onednns old acronyms used in mxnet in different contexts can be added to separate PR and if there is no objection this one can be already merged into master to avoid creating code with deprecated versions of the flags.
> 
> Can you give an example, which acronyms are you referring to?

Before v1.1 of oneDNN it was called MKLDNN, then dnnl up until some time ago. Due to that we have a mixture of different acronyms used in the code and unifying them using the most recent one can help avoid some unnecessary confusion.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-785705854

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

460992cb1266b4e40638d5d7b3fa04a68e29f174  Change MKLDNN to ONEDNN in comments surrounding changed flags


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/624a0107843cf797b29b5cd532aa3558a109e475..460992cb1266b4e40638d5d7b3fa04a68e29f174

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Sam Skalicky <no...@github.com.INVALID>.
> @bartekkuncer, do you think we can keep the old build flag and raise a warning when it's set?

This is a good idea, but we can break things. Alpha is more of a preview than something that requires API compatibility. We can merge this change now and it can show up in the Beta or the final release. 

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-786817126

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 3 commits.

38612d1a1e8224feb51d3375253861d5e8a4fb32  Change USE_MKLDNN flag to USE_ONEDNN
35d431b83f795a61874133a4d2ff6c8005a05377  Add Bartosz Kuncer to contributors
fac82dc503d113a0d5cca6b3c75c5f8b04b3708c  Change 3rdparty/mkldnn folder name to 3rdparty/onednn


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/8fbfa4e3f8b5efb61d1aa3a1f720c9a8d27c8824..fac82dc503d113a0d5cca6b3c75c5f8b04b3708c

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Andrzej Kotłowski <no...@github.com.INVALID>.
@anko-intel commented on this pull request.

I am ok with the changes already made to being merged as is (additional fixes could be made in separate PR).

> @@ -399,7 +399,7 @@ If ctypes is used, it must be `mxnet._ctypes.ndarray.NDArrayBase`.
   - Values: 0(false) or 1(true) ```(default=1)```
   - If this variable is set, MXNet will simplify the computation graph, eliminating duplicated operations on the same inputs.
 
-* MXNET_USE_MKLDNN_RNN
+* MXNET_USE_ONEDNN_RNN
   - Values: 0(false) or 1(true) ```(default=1)```
   - This variable controls whether to use the MKL-DNN backend in fused RNN operator for CPU context. There are two fusion implementations of RNN operator in MXNet. The MKL-DNN implementation has a better performance than the naive one, but the latter is more stable in the backward operation currently.

old name

>  if(USE_MKL_IF_AVAILABLE AND (NOT APPLE) AND (NOT MSVC) AND (CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "x86_64") AND (NOT CMAKE_CROSSCOMPILING))
-  option(USE_MKLDNN "Build with MKL-DNN support" ON)
+  option(USE_ONEDNN "Build with MKL-DNN support" ON)

Why one DNN depends on existing of MKL library ? Is oneDNN still dependent on MKL?

> @@ -62,18 +62,18 @@ To achieve better performance, the Intel OpenMP and llvm OpenMP are recommended
 ```

Old MKL-DNN names starting from line 18.
Maybe the directory and file name could be also changed

> @@ -327,7 +327,7 @@ If ctypes is used, it must be `mxnet._ctypes.ndarray.NDArrayBase`.
 * MXNET_MKLDNN_ENABLED
   - Values: 0, 1 ```(default=1)```
   - Flag to enable or disable MKLDNN accelerator. On by default.
-  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_MKLDNN=1```)
+  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_ONEDNN=1```)

should be ``pip install mxnet`` as oneDNN is enabled by default


> @@ -327,7 +327,7 @@ If ctypes is used, it must be `mxnet._ctypes.ndarray.NDArrayBase`.
 * MXNET_MKLDNN_ENABLED
   - Values: 0, 1 ```(default=1)```
   - Flag to enable or disable MKLDNN accelerator. On by default.
-  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_MKLDNN=1```)
+  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_ONEDNN=1```)

l329 OneDNN ?

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#pullrequestreview-598439015

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

fb1a506e0099d6073e22f65220d47c7ebd3e8fde  Remove unnecessary coma from ci/jenkins/Jenkins_steps.groovy file


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/f3e06884008d5fe3f52ed7320481865d9f085f8a..fb1a506e0099d6073e22f65220d47c7ebd3e8fde

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Sheng Zha <no...@github.com.INVALID>.
Looks like the merge issue still exists and I'm still not sure what's causing it after searching jenkins jira (e.g. [this one](https://issues.jenkins.io/browse/JENKINS-44598). Maybe you could try squashing the 6 commits to a single one and push again?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-795855255

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
Added commit regarding changing name of the submodule directory.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-785123418

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@szha @samskalicky @leezu Hi, I am struggling to find the reason why website and windows-gpu checks are failing. I see in the logs that there was a problem during `git merge` but locally, here on github and in other checks I do not see such problems. It seems like all the failing checks are run on the same machine `Running on utility_0se3punbeq in /home/jenkins_slave/workspace/xnet-validation_website_PR-19944`. Do you know what is/might be the problem here or have an advice on how should I proceed to find the issue in the fastest way? Maybe there are some artifacts which interrupt the merge? Thanks for your attention. I’m looking forward to your reply.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-794353153

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Leonard Lausen <no...@github.com.INVALID>.
> @szha Sure, thanks for help. It is quite strange that the merging worked for all other checks.

I suspect the status for the other checks was outdated. For cost savings, the Sanity check is triggered automatically by Github if needed and the other checks are only retriggered if the Sanity check passed.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-790763596

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@TaoLv it might if somebody is trying to build mxnet without mkldnn, as the old compilation flag will not work.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-786457204

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

ce179e5dd3f8da9dedc41859412036ce6bd20df7  Change inner mxnet flags nomenclature for oneDNN library


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/0c0982a8a05b40c8719f97cd3ad59ba6e72970a0..ce179e5dd3f8da9dedc41859412036ce6bd20df7

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Leonard Lausen <no...@github.com.INVALID>.
@leezu approved this pull request.





-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#pullrequestreview-596439276

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
I adjusted the change of USE_MKLDNN flags to USE_ONEDNN by changing the library name in comments around it.
The changes regarding the USE_MKLDNN compilation flag, submodule directory name and the MXNET_USE_(MKL)ONEDNN seem to be complete.

After team discussion we agreed that as having all oneDNNs acronyms unified to one is desirable, it is impossible to be achieved as long as there is no update of oneDNNs functions/flags names from dnnl*/mkldnn* nomenclature. Therefore we believe that further efforts to unify oneDNNs acronyms should be postponed at least till we get an updated api.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-785885657

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 2 commits.

5a973b2720cf191e673d0f9ca97af380a5d6132c  Add Bartosz Kuncer to contributors
8fbfa4e3f8b5efb61d1aa3a1f720c9a8d27c8824  Change 3rdparty/mkldnn folder name to 3rdparty/onednn


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/dfe07dc2c98de5e741d243008ec917f5e1b8d55f..8fbfa4e3f8b5efb61d1aa3a1f720c9a8d27c8824

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer commented on this pull request.



> @@ -327,7 +327,7 @@ If ctypes is used, it must be `mxnet._ctypes.ndarray.NDArrayBase`.
 * MXNET_MKLDNN_ENABLED
   - Values: 0, 1 ```(default=1)```
   - Flag to enable or disable MKLDNN accelerator. On by default.
-  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_MKLDNN=1```)
+  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_ONEDNN=1```)

Changed.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#discussion_r588401163

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Sheng Zha <no...@github.com.INVALID>.
@szha pushed 6 commits.

6fcfaee890b42dcc8a701905dc7c2aed748f4a27  Change flag MXNET_USE_MKLDNN to MXNET_USE_ONEDNN
943059f43441b226309c3436f7013ffb0c96dcd9  Change USE_MKLDNN flag to USE_ONEDNN
c70453cacaa0551b7b03c910b0529efe786f9a79  Add Bartosz Kuncer to contributors
ee78facc3a232df5586f63bfa4e15f6920c876c1  Change 3rdparty/mkldnn folder name to 3rdparty/onednn
88fbcaa3ac7b8e58a1d5113e0b190a2bf89d57ed  Add back support for USE_MKLDNN flag with deprecation warning
56f32e45ea905e5b21fc4fd807ed8e222cffe0d7  Change MKLDNN to ONEDNN in comments surrounding changed flags


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/a5ad2239c8974b1e8c49e73aeee9ea75891da71c..56f32e45ea905e5b21fc4fd807ed8e222cffe0d7

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Sam Skalicky <no...@github.com.INVALID>.
@samskalicky approved this pull request.

LGTM, thanks for this enhancement!



-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#pullrequestreview-598811267

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Sheng Zha <no...@github.com.INVALID>.
Merged #19944 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#event-4459823494

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

0c0982a8a05b40c8719f97cd3ad59ba6e72970a0  Merge branch 'master' into buildwithonednn


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/415f90c6e891558a4d9af608621efff4e450e51f..0c0982a8a05b40c8719f97cd3ad59ba6e72970a0

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

03f8e28c1f59d97b7c437d868c60c1f386248ca9  Change inner mxnet flags nomenclature for oneDNN library


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/be72ba1985aa07118e00dc22c4170191eead4675..03f8e28c1f59d97b7c437d868c60c1f386248ca9

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

2a0192e509130468ddef8e11b94de686e66deb1c  Change MKLDNN to ONEDNN in comments surrounding changed flags


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/460992cb1266b4e40638d5d7b3fa04a68e29f174..2a0192e509130468ddef8e11b94de686e66deb1c

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
> > @bartekkuncer, do you think we can keep the old build flag and raise a warning when it's set?
> 
> This is a good idea, but we can break things. Alpha is more of a preview than something that requires API compatibility. We can merge this change now and it can show up in the Beta or the final release.

@samskalicky I did not comment on that but already added back the support for an old flag: https://github.com/apache/incubator-mxnet/pull/19944/commits/020c892e9509e0a8a3ca5298d802fbf8e371812a.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-787700691

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

3b7d4cbbab7b87b981212f86f5db696d2ee45454  Change inner mxnet flags nomenclature for oneDNN library


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/ce179e5dd3f8da9dedc41859412036ce6bd20df7..3b7d4cbbab7b87b981212f86f5db696d2ee45454

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

020c892e9509e0a8a3ca5298d802fbf8e371812a  Add back support for USE_MKLDNN flag with deprecation warning


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/083bfcdf1fc2a7dc295d5eeb6bf47656738a5f14..020c892e9509e0a8a3ca5298d802fbf8e371812a

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@szha @leezu @samskalicky Please help with the merge.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-799545535

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Tao Lv <no...@github.com.INVALID>.
@leezu, do we claim any API compatibility on an alpha release or is it possible to include this into the alpha release?

@bartekkuncer, do you think we can keep the old build flag and raise a warning when it's set? 

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-786462847

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

b904fec02bb55002612d865b9b432aeebc279868  Change inner mxnet flags nomenclature for oneDNN library


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/8cfbe5a3e344120840ff28a49fdaae01c5e36f5c..b904fec02bb55002612d865b9b432aeebc279868

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

380344f40a846ee2e1b99b2ff75a7324800d6323  Change mxnet inner nomenclature of oneDNN library from MKLDNN to ONEDNN


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/d5ac6f727ad079712c445b00244818018b417b16..380344f40a846ee2e1b99b2ff75a7324800d6323

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

78ac83ef6a5118b27d4700ef21b415fea138f7c7  Change MKLDNN to ONEDNN in comments surrounding changed flags


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/65c65d6ea9062e1ac56ccfdfdc7773e439946c88..78ac83ef6a5118b27d4700ef21b415fea138f7c7

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Sam Skalicky <no...@github.com.INVALID>.
> There is also another idea to change the 3rdparty/mkldnn folder name to 3rdparty/onednn for consistency. The problem is that it will create unnecessary difference in directories names between branches.

since this is the master branch, and we're moving from 1.x to 2.0 shouldnt this be the time to make this change? Having a directory named "mkldnn" but using "onednn" everywhere will only cause confusion in the future for those who do not have the historical background. 

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-784430683

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

5f2789573c176931bbbfe89cb675f4e7a3e1b9e1  This change includes:


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/380344f40a846ee2e1b99b2ff75a7324800d6323..5f2789573c176931bbbfe89cb675f4e7a3e1b9e1

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

d5ac6f727ad079712c445b00244818018b417b16  Change mxnet inner nomenclature of oneDNN library from MKLDNN to ONEDNN


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/3fb9bc672853433310db9fae65ece69b1596dd4b..d5ac6f727ad079712c445b00244818018b417b16

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer commented on this pull request.



>  if(USE_MKL_IF_AVAILABLE AND (NOT APPLE) AND (NOT MSVC) AND (CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL "x86_64") AND (NOT CMAKE_CROSSCOMPILING))
-  option(USE_MKLDNN "Build with MKL-DNN support" ON)
+  option(USE_ONEDNN "Build with MKL-DNN support" ON)

This will be addressed in separate PR.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#discussion_r589347835

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer requested your review on: apache/incubator-mxnet#19944 [RFC] Build with MKL-DNN (or DNNL) as a code owner.

-- 
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#event-4365089303

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

a5ad2239c8974b1e8c49e73aeee9ea75891da71c  Change MKLDNN to ONEDNN in comments surrounding changed flags


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/2a0192e509130468ddef8e11b94de686e66deb1c..a5ad2239c8974b1e8c49e73aeee9ea75891da71c

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer commented on this pull request.



> @@ -327,7 +327,7 @@ If ctypes is used, it must be `mxnet._ctypes.ndarray.NDArrayBase`.
 * MXNET_MKLDNN_ENABLED
   - Values: 0, 1 ```(default=1)```
   - Flag to enable or disable MKLDNN accelerator. On by default.
-  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_MKLDNN=1```)
+  - Only applies to mxnet that has been compiled with MKLDNN (```pip install mxnet-mkl``` or built from source with ```USE_ONEDNN=1```)

Changed.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#discussion_r588401375

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by Sheng Zha <no...@github.com.INVALID>.
@bartekkuncer no idea. Because sanity check is a required check, committers can't click on merge button if it's not green.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-789827387

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 0 commits.



-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/a5ad2239c8974b1e8c49e73aeee9ea75891da71c..4f43d96c8e7e5d832ce25957936b02138b8da1ad

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
> @leezu, do we claim any API compatibility on an alpha release or is it possible to include this into the alpha release?
> 
> @bartekkuncer, do you think we can keep the old build flag and raise a warning when it's set?

@TaoLv I believe we might keep it for some time. Will add it by eod.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-786464386

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

3fb9bc672853433310db9fae65ece69b1596dd4b  Change mxnet inner nomenclature of oneDNN library from MKLDNN to ONEDNN


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/56f32e45ea905e5b21fc4fd807ed8e222cffe0d7..3fb9bc672853433310db9fae65ece69b1596dd4b

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

cf40e6528f381c5e63bd13d9c3f60845a42e61df  Change inner mxnet flags nomenclature for oneDNN library


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/3b7d4cbbab7b87b981212f86f5db696d2ee45454..cf40e6528f381c5e63bd13d9c3f60845a42e61df

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 2 commits.

1b8e616718759e8a53e9e20ff29e8f05a17cf04d  Change 3rdparty/mkldnn folder name to 3rdparty/onednn
65c65d6ea9062e1ac56ccfdfdc7773e439946c88  Add back support for USE_MKLDNN flag with deprecation warning


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/75ed660c31cb1d27ffb01e3afb14b8387139ad19..65c65d6ea9062e1ac56ccfdfdc7773e439946c88

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
CC: @leezu, @TaoLv, @anko-intel, @szha, @akarbown 

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-784252538

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
I think that the commits regarding updating onednns old acronyms used in mxnet in different contexts can be added to separate PR and if there is no objection this one can be already merged into master to avoid creating code with deprecated versions of the flags.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944#issuecomment-785199514

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

72e3ec17add7fc9dcc8a1ed4bbac33d6fc583016  Improve building with oneDNN


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/7deb49936587cebe4463dbe080b9b7b6d3bb70a4..72e3ec17add7fc9dcc8a1ed4bbac33d6fc583016

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 1 commit.

ec69d2910205bac1ca5b3b97b3edf49025e6319b  Change inner mxnet flags nomenclature for oneDNN library


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/03f8e28c1f59d97b7c437d868c60c1f386248ca9..ec69d2910205bac1ca5b3b97b3edf49025e6319b

Re: [apache/incubator-mxnet] [RFC] Build with MKL-DNN (or DNNL) (#19944)

Posted by bartekkuncer <no...@github.com.INVALID>.
@bartekkuncer pushed 3 commits.

74f62c18614d7f7f1b3c208fd73530ffbbc4fb17  Change USE_MKLDNN flag to USE_ONEDNN
d601448c38da4da59296e3557f377acc4090c377  Add Bartosz Kuncer to contributors
083bfcdf1fc2a7dc295d5eeb6bf47656738a5f14  Change 3rdparty/mkldnn folder name to 3rdparty/onednn


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/apache/incubator-mxnet/pull/19944/files/fac82dc503d113a0d5cca6b3c75c5f8b04b3708c..083bfcdf1fc2a7dc295d5eeb6bf47656738a5f14