You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@metron.apache.org by cestella <gi...@git.apache.org> on 2018/07/02 16:25:15 UTC

[GitHub] metron pull request #1082: METRON-1642: KafkaWriter should be able choose th...

Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1082#discussion_r199552106
  
    --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/kafka/KafkaWriter.java ---
    @@ -197,6 +209,15 @@ public void init(Map stormConf, TopologyContext topologyContext, WriterConfigura
         return producerConfig;
       }
     
    +  public Optional<String> getKafkaTopic(JSONObject message) {
    --- End diff --
    
    They absolutely could create loops in kafka, which wouldn't be ideal.  I don't know how I could prevent it, sadly.  I think this falls in the "with great power comes great responsibility".  Should we call this a spiderman bug (spiderbug?).


---