[GitHub] [airflow] hussein-awala commented on issue #29663: Option to Disable High Cardinality Metrics on Statsd

["hussein-awala (via GitHub)" <gi...@apache.org>]

hussein-awala commented on issue #29663:
URL: https://github.com/apache/airflow/issues/29663#issuecomment-1442583976

   I have checked with DataDog, and as I mentioned in my [PR](https://github.com/apache/airflow/pull/28961#issue-1533973742), activating this option will increase the cost, but the difference between the metrics with tags and the old prefixed metrics is just the `dag_run_id` and `job_id` for callbacks.
   
   But as @potiuk has mentioned [before](https://github.com/apache/airflow/pull/28961#issuecomment-1435655836), this detailed information could be an important part of OTEL specification, so I suggest adding a new boolean config `detailed_metrics` with default value `False` to enable/disable `dag_run_id` and `job_id`  tags or a new string config `disabled_tags` which allows user to provide a list of tags he wants to disable separated by a comma, and we use `"dag_run_id,job_id"` as default value.
   
   I prefer the second option because it's more dynamic, and we can use it to disable one of the two tags or another different tag. 
   
   @potiuk what do you think?
   
   (@syun64 I have assigned it to you.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org