You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2016/04/14 00:52:04 UTC
Review Request 46178: AMBARI-15872 : Provide ability to skip WAL file
writes for AMS HBase tables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46178/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-15872
https://issues.apache.org/jira/browse/AMBARI-15872
Repository: ambari
Description
-------
For large clusters, this is a very useful optimization that can be employed.
Added an optional config (Not available through default from the stack)
ams-site : timeline.metrics.tables.durability
Valid values it can take : SKIP_WAL / SYNC_WAL / ASYNC_WAL / FSYNC_WAL
Diffs
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 813387f
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java 0ebc248
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 89f3fbe
Diff: https://reviews.apache.org/r/46178/diff/
Testing
-------
Manually tested.
Added unit test.
Thanks,
Aravindan Vijayan
Re: Review Request 46178: AMBARI-15872 : Provide ability to skip WAL
file writes for AMS HBase tables
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46178/#review128792
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On April 13, 2016, 10:52 p.m., Aravindan Vijayan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46178/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 10:52 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-15872
> https://issues.apache.org/jira/browse/AMBARI-15872
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For large clusters, this is a very useful optimization that can be employed.
>
> Added an optional config (Not available through default from the stack)
>
> ams-site : timeline.metrics.tables.durability
> Valid values it can take : SKIP_WAL / SYNC_WAL / ASYNC_WAL / FSYNC_WAL
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java 813387f
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java 0ebc248
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java 89f3fbe
>
> Diff: https://reviews.apache.org/r/46178/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
> Added unit test.
>
>
> Thanks,
>
> Aravindan Vijayan
>
>