You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Sahil Takiar (JIRA)" <ji...@apache.org> on 2019/01/25 15:23:00 UTC

[jira] [Updated] (IMPALA-8117) KuduCatalogOpExecutor.validateKuduTblExists does not check if Kudu table exists

     [ https://issues.apache.org/jira/browse/IMPALA-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sahil Takiar updated IMPALA-8117:
---------------------------------
    Description: 
The code for {{KuduCatalogOpExecutor.validateKuduTblExists}} is:

{code:java}
    KuduClient kudu = KuduUtil.getKuduClient(masterHosts);
    try {
      kudu.tableExists(kuduTableName);
    } catch (Exception e) {
      // TODO: This is misleading when there are other errors, e.g. timeouts.
      throw new ImpalaRuntimeException(String.format("Kudu table '%s' does not exist " +
          "on master '%s'", kuduTableName, masterHosts), e);
    }
{code}

The issue is that {{kudu.tableExists}} returns {{true}} if the table exists, {{false}} if it does not. So this method does not actually check if the table exists.

I went through the rest of the code in {{KuduCatalogOpExecutor}} and it looks like all other uses of {{kudu.tableExists}} properly check the return value of the method.

> KuduCatalogOpExecutor.validateKuduTblExists does not check if Kudu table exists
> -------------------------------------------------------------------------------
>
>                 Key: IMPALA-8117
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8117
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Catalog
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>            Priority: Major
>
> The code for {{KuduCatalogOpExecutor.validateKuduTblExists}} is:
> {code:java}
>     KuduClient kudu = KuduUtil.getKuduClient(masterHosts);
>     try {
>       kudu.tableExists(kuduTableName);
>     } catch (Exception e) {
>       // TODO: This is misleading when there are other errors, e.g. timeouts.
>       throw new ImpalaRuntimeException(String.format("Kudu table '%s' does not exist " +
>           "on master '%s'", kuduTableName, masterHosts), e);
>     }
> {code}
> The issue is that {{kudu.tableExists}} returns {{true}} if the table exists, {{false}} if it does not. So this method does not actually check if the table exists.
> I went through the rest of the code in {{KuduCatalogOpExecutor}} and it looks like all other uses of {{kudu.tableExists}} properly check the return value of the method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org