You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by mc...@apache.org on 2025/10/27 10:08:19 UTC

(cassandra) branch cassandra-4.1 updated: ninja-fix – Fix (again) eclipse-warnings error for CASSANDRA-19564

This is an automated email from the ASF dual-hosted git repository.

mck pushed a commit to branch cassandra-4.1
in repository https://gitbox.apache.org/repos/asf/cassandra.git


The following commit(s) were added to refs/heads/cassandra-4.1 by this push:
     new fdc422c16f ninja-fix – Fix (again) eclipse-warnings error for CASSANDRA-19564
fdc422c16f is described below

commit fdc422c16fa6bc4a534f3b8636e016b0fa1174f3
Author: Mick Semb Wever <mc...@apache.org>
AuthorDate: Mon Oct 27 10:31:08 2025 +0100

    ninja-fix – Fix (again) eclipse-warnings error for CASSANDRA-19564
---
 src/java/org/apache/cassandra/index/SecondaryIndexManager.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/java/org/apache/cassandra/index/SecondaryIndexManager.java b/src/java/org/apache/cassandra/index/SecondaryIndexManager.java
index fe015ead16..ea248fc694 100644
--- a/src/java/org/apache/cassandra/index/SecondaryIndexManager.java
+++ b/src/java/org/apache/cassandra/index/SecondaryIndexManager.java
@@ -898,6 +898,7 @@ public class SecondaryIndexManager implements IndexRegistry, INotificationConsum
      * @param pageSize the number of {@link Unfiltered} objects to process in a single page
      * @param columns the columns indexed by at least one of the supplied indexes
      */
+    @SuppressWarnings("resource") // for `UnfilteredRowIterator partition` as it is closed later in finally block
     public void indexPartition(DecoratedKey key, Set<Index> indexes, int pageSize, RegularAndStaticColumns columns)
     {
         if (logger.isTraceEnabled())
@@ -919,7 +920,6 @@ public class SecondaryIndexManager implements IndexRegistry, INotificationConsum
             SinglePartitionPager pager = new SinglePartitionPager(cmd, null, ProtocolVersion.CURRENT);
             while (!pager.isExhausted())
             {
-                @SuppressWarnings("resource")
                 UnfilteredRowIterator partition;
                 try (ReadExecutionController controller = cmd.executionController();
                      UnfilteredPartitionIterator page = pager.fetchPageUnfiltered(baseCfs.metadata(), pageSize, controller))


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org