You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by bu...@apache.org on 2009/09/08 14:09:14 UTC
DO NOT REPLY [Bug 47800] New: CSS scanner does not tokenize
correctly CSS properties starting with '-' such as -moz-border-radius
https://issues.apache.org/bugzilla/show_bug.cgi?id=47800
Summary: CSS scanner does not tokenize correctly CSS properties
starting with '-' such as -moz-border-radius
Product: Batik
Version: 1.8
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: CSS
AssignedTo: batik-dev@xmlgraphics.apache.org
ReportedBy: nivco@google.com
--- Comment #0 from Nicolas Garnier <ni...@google.com> 2009-09-08 05:09:12 PDT ---
Created an attachment (id=24226)
Corrected Scanner.java
CSS properties such as -moz-border-radius or -webkit-border-radius (all
properties starting with '-') are not tokenized correctly by the CSS scanner.
Instead of being tokenized as LexicalUnits.IDENTIFIER the first character is
tokenized as LexicalUnits.MINUS and the rest of the properties fails to
tokenize.
Corrected version of the Scanner.java file is attached.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 47800] [PATCH] CSS scanner does not tokenize
correctly CSS properties starting with '-' such as -moz-border-radius
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47800
Nicolas Garnier <ni...@google.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|CSS scanner does not |[PATCH] CSS scanner does
|tokenize correctly CSS |not tokenize correctly CSS
|properties starting with |properties starting with
|'-' such as |'-' such as
|-moz-border-radius |-moz-border-radius
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 47800] [PATCH] CSS scanner does not tokenize
correctly vendor specific CSS properties (such as -moz-border-radius)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47800
Nicolas Garnier <ni...@google.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24226|0 |1
is obsolete| |
Attachment #24230|0 |1
is obsolete| |
--- Comment #6 from Nicolas Garnier <ni...@google.com> 2009-10-07 12:13:22 PDT ---
Created an attachment (id=24359)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24359)
PATCH file for Scanner.java
Hey Helder,
Here is the PATCH file for Batik 1.8
(The bug was still there in Batik 1.8)
I hope this one will be the good one :D
Cheers!
Thanks again for your time
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 47800] [PATCH] CSS scanner does not tokenize
correctly vendor specific CSS properties (such as -moz-border-radius)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47800
--- Comment #4 from Helder Magalhães <he...@gmail.com> 2009-09-18 06:18:49 PDT ---
(In reply to comment #3)
> The batik release I worked on is Batik 1.6 (checkout out from the tags tree)
This is a pretty outdated version... :-|
> Please tell me if any regressions occurred or any other pbs.
Regressions in which sense? Typically, one tries to assure no regressions are
made. What may be happening is that you fix is already included in the current
trunk version (1.8, as of this writing).
I'd invite you to compare the trunk source with the version 1.6 code and try to
attach a patch to the current trunk version: as far as I know, there is no work
in legacy versions. At least, that's what I would to in order to try
integrating your bug fix into the trunk code... ;-)
I may be able to get my hands into this, but I currently can't predict if nor
when.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 47800] [PATCH] CSS scanner does not tokenize
correctly CSS properties starting with '-' such as -moz-border-radius
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47800
--- Comment #2 from Nicolas Garnier <ni...@google.com> 2009-09-08 10:43:27 PDT ---
Created an attachment (id=24230)
PATCH file for Scanner.java
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 47800] [PATCH] CSS scanner does not tokenize
correctly vendor specific CSS properties (such as -moz-border-radius)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47800
Helder Magalhães <he...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
Version|1.6 |1.8
--- Comment #7 from Helder Magalhães <he...@gmail.com> 2009-10-18 09:24:25 UTC ---
(In reply to comment #6)
> Here is the PATCH file for Batik 1.8
> (The bug was still there in Batik 1.8)
Updated target version accordingly.
> I hope this one will be the good one :D
Thanks, Nicolas! :-)
The patch now needs to be reviewed/committed by someone commit rights. Thomas,
could you take a look at this and/or detail on further steps which are needed
(regard test cases, maybe?) before this can be landed?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 47800] [PATCH] CSS scanner does not tokenize
correctly CSS properties starting with '-' such as -moz-border-radius
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47800
Nicolas Garnier <ni...@google.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|1.8 |1.6
--- Comment #3 from Nicolas Garnier <ni...@google.com> 2009-09-08 10:45:15 PDT ---
Hey Helder,
Thanks a lot for looking into this!
Sorry about not posting a patch file, it was pretty late last night and I
really had to got to bed :D
The batik release I worked on is Batik 1.6 (checkout out from the tags tree)
I attached a PATCH file this time.
Please tell me if any regressions occurred or any other pbs.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 47800] [PATCH] CSS scanner does not tokenize
correctly CSS properties starting with '-' such as -moz-border-radius
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47800
--- Comment #1 from Helder Magalhães <he...@gmail.com> 2009-09-08 07:55:35 PDT ---
(In reply to comment #0)
> Created an attachment (id=24226) [details]
> Corrected Scanner.java
Thanks for the report and the correction proposal. :-)
> Corrected version of the Scanner.java file is attached.
(Also about adding the "[PATCH]" prefix...) Note that attaching a patched file
is not the same as attaching a patch. ;-)
I've tried to merge your file with the current trunk code but, given you
provided no information about the Batik release where the file was taken, the
process can harder. Please provide this information (Batik release and/or
revision where this file was taken from) or attach a "real" patch (even better,
if you are able to).
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 47800] [PATCH] CSS scanner does not tokenize
correctly vendor specific CSS properties (such as -moz-border-radius)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47800
Nicolas Garnier <ni...@google.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[PATCH] CSS scanner does |[PATCH] CSS scanner does
|not tokenize correctly CSS |not tokenize correctly
|properties starting with |vendor specific CSS
|'-' such as |properties (such as
|-moz-border-radius |-moz-border-radius)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 47800] [PATCH] CSS scanner does not tokenize
correctly vendor specific CSS properties (such as -moz-border-radius)
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47800
--- Comment #5 from Nicolas Garnier <ni...@google.com> 2009-09-29 14:05:02 PDT ---
Hey Helder,
Sorry about the delay, I'm a little swamped at work but as soon as I can get
some time I'll submit a patch for batik 1.8 (that should not be a pb). The bug
still seems to be there in 1.8 but, just in case, I'll run some more tests when
as soon as that crazy period at work is over :)
Cheers!
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org