[GitHub] [flink] danny0405 commented on a change in pull request #8966: [FLINK-13074][table-planner-blink] Add PartitionableTableSink bridge logic to flink&blink …

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #8966: [FLINK-13074][table-planner-blink] Add PartitionableTableSink bridge logic to flink&blink …
URL: https://github.com/apache/flink/pull/8966#discussion_r304246502
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/calcite/PreValidateReWriter.scala
 ##########
 @@ -99,12 +99,15 @@ object PreValidateReWriter {
       case t: RelOptTable => t
       case _ => null
     }
+    def tester(idx: Integer): Boolean = {
+      !assignedFields.contains(idx)
+    }
     for (node <- partitions.getList) {
       val sqlProperty = node.asInstanceOf[SqlProperty]
       val id = sqlProperty.getKey
       val targetField = SqlValidatorUtil.getTargetField(targetRowType,
         typeFactory, id, calciteCatalogReader, relOptTable)
-      validateField(assignedFields.containsValue, id, targetField)
+      validateField(tester, id, targetField)
 
 Review comment:
   Yeah, we could.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services