You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by bo...@apache.org on 2015/04/22 23:13:26 UTC
[3/7] storm git commit: add additional information to error message
when ShellBolt dies
add additional information to error message when ShellBolt dies
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/9869fec7
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/9869fec7
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/9869fec7
Branch: refs/heads/master
Commit: 9869fec70bdb06b14cc13ffca69320815950d1f5
Parents: 5628444
Author: P. Taylor Goetz <pt...@gmail.com>
Authored: Mon Apr 6 17:03:15 2015 -0400
Committer: P. Taylor Goetz <pt...@gmail.com>
Committed: Mon Apr 6 17:03:15 2015 -0400
----------------------------------------------------------------------
storm-core/src/jvm/backtype/storm/task/ShellBolt.java | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/9869fec7/storm-core/src/jvm/backtype/storm/task/ShellBolt.java
----------------------------------------------------------------------
diff --git a/storm-core/src/jvm/backtype/storm/task/ShellBolt.java b/storm-core/src/jvm/backtype/storm/task/ShellBolt.java
index 308ec67..eac8a90 100644
--- a/storm-core/src/jvm/backtype/storm/task/ShellBolt.java
+++ b/storm-core/src/jvm/backtype/storm/task/ShellBolt.java
@@ -279,7 +279,10 @@ public class ShellBolt implements IBolt {
private void die(Throwable exception) {
String processInfo = _process.getProcessInfoString() + _process.getProcessTerminationInfoString();
_exception = new RuntimeException(processInfo, exception);
- LOG.error("Halting process: ShellBolt died.", exception);
+ String message = String.format("Halting process: ShellBolt died. Command: %s, ProcessInfo %s",
+ Arrays.toString(_command),
+ processInfo);
+ LOG.error(message, exception);
_collector.reportError(exception);
if (_running || (exception instanceof Error)) { //don't exit if not running, unless it is an Error
System.exit(11);