You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "gautamguptabasant (via GitHub)" <gi...@apache.org> on 2023/09/12 13:27:34 UTC
[GitHub] [gobblin] gautamguptabasant opened a new pull request, #3766: Salesforce: Early stop for single partition
gautamguptabasant opened a new pull request, #3766:
URL: https://github.com/apache/gobblin/pull/3766
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- As per the current implementation, early stop is enabled only when multi-partition is also configured.
- As part of this change, we are enabling the support for single partition configuration as well.
- FYI, early stop is a way to limit the number of records that are fetched/ingested from the CRM source.
### Tests
- The current organization of the SalesforceSource class makes it super hard to add tests. Hence not adding tests as part of this tiny change.
- Taking up refactoring of the class as an immediate follow up item, where I will be moving the histogram related code to a new service class. Doing so, we would be able to mock those methods and hence easily write tests for the logic in this class.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3766: Salesforce: Early stop for single partition
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3766:
URL: https://github.com/apache/gobblin/pull/3766#issuecomment-1716132672
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3766?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3766](https://app.codecov.io/gh/apache/gobblin/pull/3766?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7f8930d) into [master](https://app.codecov.io/gh/apache/gobblin/commit/b8444fa2f41c2c13e79bd993d0fd7da471b3fa7c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b8444fa) will **decrease** coverage by `1.40%`.
> Report is 1 commits behind head on master.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3766 +/- ##
============================================
- Coverage 47.17% 45.78% -1.40%
+ Complexity 10906 2158 -8748
============================================
Files 2148 413 -1735
Lines 85059 17965 -67094
Branches 9442 2187 -7255
============================================
- Hits 40129 8225 -31904
+ Misses 41285 8866 -32419
+ Partials 3645 874 -2771
```
| [Files Changed](https://app.codecov.io/gh/apache/gobblin/pull/3766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rg/apache/gobblin/salesforce/SalesforceSource.java](https://app.codecov.io/gh/apache/gobblin/pull/3766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2FsZXNmb3JjZVNvdXJjZS5qYXZh) | `20.00% <100.00%> (ø)` | |
... and [1741 files with indirect coverage changes](https://app.codecov.io/gh/apache/gobblin/pull/3766/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] Will-Lo merged pull request #3766: [GOBBLIN-1903] Salesforce: Early stop for single partition
Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3766:
URL: https://github.com/apache/gobblin/pull/3766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org