You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ephraimbuddy (via GitHub)" <gi...@apache.org> on 2023/08/08 18:42:54 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request, #33220: Fix pydantic warning about `orm_mode` rename
ephraimbuddy opened a new pull request, #33220:
URL: https://github.com/apache/airflow/pull/33220
Pydantic 2 renamed orm_mode to from_attributes. This was missed during the upgrade to pydantic 2 and it gives excessive warnings about the rename. This PR fixes it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #33220: Fix pydantic warning about `orm_mode` rename
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #33220:
URL: https://github.com/apache/airflow/pull/33220#issuecomment-1670928883
I added a commit to make this compatible with both Pydantic 1.x and 2.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33220: Fix pydantic warning about `orm_mode` rename
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33220:
URL: https://github.com/apache/airflow/pull/33220#issuecomment-1670340402
https://github.com/apache/airflow/pull/33235 - PR ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33220: Fix pydantic warning about `orm_mode` rename
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33220:
URL: https://github.com/apache/airflow/pull/33220#issuecomment-1670329174
Why don't we simply limit pydantic to <2 for now ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #33220: Fix pydantic warning about `orm_mode` rename
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #33220:
URL: https://github.com/apache/airflow/pull/33220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #33220: Fix pydantic warning about `orm_mode` rename
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on PR #33220:
URL: https://github.com/apache/airflow/pull/33220#issuecomment-1670318196
Looks like we can't fix this due to breeze having pydantic 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org