You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Jefffrey (via GitHub)" <gi...@apache.org> on 2025/10/07 06:43:21 UTC

[I] Fuzz underlying physical types for logical types in sqllogictests [datafusion]

Jefffrey opened a new issue, #17947:
URL: https://github.com/apache/datafusion/issues/17947

   ### Is your feature request related to a problem or challenge?
   
   If we have a function that accepts a string argument, this could be provided as `Utf8`, `LargeUtf8`, `Utf8View`, or via a `Dictionary` type; In SLT tests we would have to ensure we cover all these input types to ensure we don't accidentally miss an implementation.
   
   ### Describe the solution you'd like
   
   Have a way in our SLT tests to fuzz the physical types of logical types; this extends to lists (`List`, `LargeList`, `FixedSizeList`) and other types too. Would need to consider tests which check the output type as well since those could be dependent on the input type.
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   Spawned from comment here: https://github.com/apache/datafusion/issues/13408#issuecomment-3368478752


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Fuzz underlying physical types for logical types in sqllogictests [datafusion]

Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on issue #17947:
URL: https://github.com/apache/datafusion/issues/17947#issuecomment-3378093060

   > We have done that on string UTs: https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/string/README.md
   
   the current approach is not the best for testing cases mixing various string types.
   it also works only for test cases which do not provide input data with VALUES 
   
   so +1 for fuzzying within SLT runner.
   
   as noted https://github.com/apache/datafusion/issues/13408#issuecomment-3368478752, this can be applied directly to string literals (`'...'` values) within the SQL-to-LP layer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Fuzz underlying physical types for logical types in sqllogictests [datafusion]

Posted by "2010YOUY01 (via GitHub)" <gi...@apache.org>.
2010YOUY01 commented on issue #17947:
URL: https://github.com/apache/datafusion/issues/17947#issuecomment-3375620266

   We have done that on string UTs: https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/string/README.md
   
   I think it's a good idea to modify slt runner somehow, to let such fuzz strategy can be automatically applied to integration tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org