You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/29 06:54:12 UTC
[GitHub] [apisix-dashboard] starsz opened a new issue #1143: request help: global_rule need create_time and update_time
starsz opened a new issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143
### Issue description
Now, the global rule schema doesn't have `create_time` and `update_time`.
I think we can add it.
https://github.com/apache/apisix/blob/9b5fa0b4c49c1eb1a12a21f5ced32a456c7c39f1/apisix/schema_def.lua#L686-L694
### Environment
* apisix version (cmd: `apisix version`): master
* OS: (cmd: `uname -a`)
* OpenResty / Nginx version: (cmd: `nginx -V` or `openresty -V`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-757972489
@imjoey Just to make sure, https://github.com/apache/apisix-dashboard/blob/master/web/src/pages/ServerInfo/List.tsx#L86-L91 if those 2 fields are returned from manager-api, then the fe will show them directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-752296635
Right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-752083125
> Now, the global rule schema doesn't have `create_time` and `update_time`.
why do we need to export this field?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-752092271
IMO, if we have `create_time` and `update_time` in `global rules` will be useful for developers. We can know the `global rules` create time and update time.
Besides, `route`, consumer` and `services` all have both fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-757988348
ok fine, for Global Rule in the FE, the Global Plugin(Global Rule actually) doesn't plan to have UI to show created_time/updated_time, please see here https://github.com/apache/apisix-dashboard/blob/d6dcaa4066acf864b2d9303e570486b5dabb9265/web/src/pages/Plugin/service.ts#L30
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz edited a comment on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
starsz edited a comment on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-752092271
IMO,`create_time` and `update_time` in `global rules` will be useful for developers. They can know the `global rules`s create time and update time.
Besides, `route`, consumer` and `services` all have both fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-757998839
> ok fine, for Global Rule in the FE, the Global Plugin(Global Rule actually) doesn't plan to have UI to show created_time/updated_time, please see here
>
> https://github.com/apache/apisix-dashboard/blob/d6dcaa4066acf864b2d9303e570486b5dabb9265/web/src/pages/Plugin/service.ts#L30
@juzhiyuan thanks for reply. If there is no plan in FE, we can close this for now. 🍻
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-757968182
@juzhiyuan cause this functionality is still not integrated in FE, so shall we keep it open for now? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-753714932
conclusion and solution?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz edited a comment on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
starsz edited a comment on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-752092271
IMO,`create_time` and `update_time` in `global rules` will be useful for developers. We can know the `global rules` create time and update time.
Besides, `route`, consumer` and `services` all have both fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-757982612
> @imjoey Just to make sure, https://github.com/apache/apisix-dashboard/blob/master/web/src/pages/ServerInfo/List.tsx#L86-L91 if those 2 fields are returned from manager-api, then the fe will show them directly.
@juzhiyuan I'm a little confused that the code you mentioned is about ServerInfo, not GlobalRule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-752094709
> IMO,`create_time` and `update_time` in `global rules` will be useful for developers. They can know the `global rules`s create time and update time.
only need to read this field for API caller, all right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1143: request help: global_rule need create_time and update_time
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1143:
URL: https://github.com/apache/apisix-dashboard/issues/1143#issuecomment-753718442
Add create_time and update_time in the `global rule` like `route`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org