You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Rodney Waldhoff <rw...@apache.org> on 2003/01/04 14:15:35 UTC
[collections] unit test failures with NodeCachingLinkedList
With the CVS head of collections, I get 2 failures and 2 errors from the
test suite (out of 2280 tests).
Here are the specific problems, along with the interesting parts of the
stack traces. As the failure messages suggest, the files
data/test/NodeCachingLinkedList.* do indeed seem to be missing from CVS
(e.g.,
<http://cvs.apache.org/viewcvs.cgi/jakarta-commons/collections/data/test/NodeCachingLinkedList.fullCollection.version1.obj>).
Failure 1:
Testcase: testCanonicalEmptyCollectionExists took 0 sec
FAILED
Canonical empty collection (data/test/NodeCachingLinkedList.emptyCollection.version1.obj) is not in CVS
junit.framework.AssertionFailedError: Canonical empty collection (data/test/NodeCachingLinkedList.emptyCollection.version1.obj) is not in CVS
at org.apache.commons.collections.TestObject.testCanonicalEmptyCollectionExists(TestObject.java:294)
at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:220)
Failure 2:
Testcase: testCanonicalEmptyCollectionExistsTestcase:
testCanonicalFullCollectionExists took 0 sec
FAILED
Canonical full collection (data/test/NodeCachingLinkedList.fullCollection.version1.obj) is not in CVS
junit.framework.AssertionFailedError: Canonical full collection (data/test/NodeCachingLinkedList.fullCollection.version1.obj) is not in CVS
at org.apache.commons.collections.TestObject.testCanonicalFullCollectionExists(TestObject.java:313)
at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:220)
Error 1:
Testcase: testEmptyListCompatibility took 0 sec
Caused an ERROR
data/test/NodeCachingLinkedList.emptyCollection.version1.obj (The system cannot find the file specified)
java.io.FileNotFoundException: data/test/NodeCachingLinkedList.emptyCollection.version1.obj (The system cannot find the file specified)
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.<init>(FileInputStream.java:64)
at org.apache.commons.collections.TestObject.readExternalFormFromDisk(TestObject.java:197)
at org.apache.commons.collections.TestList.testEmptyListCompatibility(TestList.java:894)
at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:220)
Error 2:
Testcase: testFullListCompatibility took 0 sec
Caused an ERROR
data/test/NodeCachingLinkedList.fullCollection.version1.obj (The system cannot find the file specified)
java.io.FileNotFoundException: data/test/NodeCachingLinkedList.fullCollection.version1.obj (The system cannot find the file specified)
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.<init>(FileInputStream.java:64)
at org.apache.commons.collections.TestObject.readExternalFormFromDisk(TestObject.java:197)
at org.apache.commons.collections.TestList.testFullListCompatibility(TestList.java:913)
at org.apache.commons.jelly.tags.ant.AntTag.doTag(AntTag.java:220)
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [collections] unit test failures with NodeCachingLinkedList
Posted by Sam Ruby <ru...@apache.org>.
Rodney Waldhoff wrote:
>
> By the way, this brings to my attention that gump isn't running the unit
> tests, which we should probably have it do.
Easy enough. Simply change the target in here:
http://cvs.apache.org/viewcvs.cgi/*checkout*/jakarta-gump/project/jakarta-commons.xml?rev=HEAD&content-type=text/plain
Or add "test" to the depends of the "dist" target in here:
http://cvs.apache.org/viewcvs.cgi/*checkout*/jakarta-commons/collections/build.xml?rev=HEAD&content-type=text/plain
- Sam Ruby
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [collections] unit test failures with NodeCachingLinkedList
Posted by Rodney Waldhoff <rw...@apache.org>.
Rich sent the file offlist. This pathc has now been applied.
Thanks.
On Mon, 6 Jan 2003, Rodney Waldhoff wrote:
> Rich,
>
> I'm still having trouble applying this patch (tried RH linux as well).
>
> Can you just send me your copy of NodeCachingLinkedList? That's the only
> file that's causing me trouble.
>
> On 5 Jan 2003, Rich Dougherty wrote:
>
> > Here's a repost of a patch which will fix this. Note that the
> > reimplementation of java.util.LinkedList is necessary so we can override
> > node creation and deletion without using Sun's code.
> >
> > Rich
> >
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [collections] unit test failures with NodeCachingLinkedList
Posted by Rodney Waldhoff <rw...@apache.org>.
Rich,
I'm still having trouble applying this patch (tried RH linux as well).
Can you just send me your copy of NodeCachingLinkedList? That's the only
file that's causing me trouble.
On 5 Jan 2003, Rich Dougherty wrote:
> Here's a repost of a patch which will fix this. Note that the
> reimplementation of java.util.LinkedList is necessary so we can override
> node creation and deletion without using Sun's code.
>
> Rich
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [collections] unit test failures with NodeCachingLinkedList
Posted by Rodney Waldhoff <rw...@apache.org>.
My mistake, I think. I didn't notice before that I was getting a reject
on one of the files (relative to a fresh CVS checkout), so I was still
running the old version of NodeCachingLinkedList.
I'm running patch under cygwin on win98 right now, so maybe there is
something odd here. I can try again later on other platforms, but
it'll have to wait until monday. sorry.
On 5 Jan 2003, Rich Dougherty wrote:
> > Even with this patch applied, I seem to get 2 errors, seemingly
> > serialVersionID issues (see below).
>
> I just did a fresh checkout from CVS and applied the patch and it worked
> ok for me on two different JDKs.
>
> It seems a bit odd, but perhaps you have different versions of
> NodeCachingLinkedList.emptyCollection.version2.2.obj and
> NodeCachingLinkedList.fullCollection.version2.2.obj. Can you
> double-check that you put the all the files from
> linkedlist-reimp-data.tar.gz into data/test?
>
> If that doesn't work, then we might need to do some more investigation.
> Perhaps you could send me a copy of your working directory.
>
> Rich
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [collections] unit test failures with NodeCachingLinkedList
Posted by Rich Dougherty <ri...@rd.gen.nz>.
> Even with this patch applied, I seem to get 2 errors, seemingly
> serialVersionID issues (see below).
I just did a fresh checkout from CVS and applied the patch and it worked
ok for me on two different JDKs.
It seems a bit odd, but perhaps you have different versions of
NodeCachingLinkedList.emptyCollection.version2.2.obj and
NodeCachingLinkedList.fullCollection.version2.2.obj. Can you
double-check that you put the all the files from
linkedlist-reimp-data.tar.gz into data/test?
If that doesn't work, then we might need to do some more investigation.
Perhaps you could send me a copy of your working directory.
Rich
Re: [collections] unit test failures with NodeCachingLinkedList
Posted by Rodney Waldhoff <rw...@apache.org>.
Even with this patch applied, I seem to get 2 errors, seemingly
serialVersionID issues (see below).
Also, I wonder if we might find a less "common" name than
CommonsLinkedList (perhaps ExtensibleLinkedList if that's the intention?),
but thats a minor issue (we could always change it before release)
By the way, this brings to my attention that gump isn't running the unit
tests, which we should probably have it do.
Testcase: testEmptyListCompatibility took 0 sec
Caused an ERROR
org.apache.commons.collections.NodeCachingLinkedList; Local class not
compatible: stream classdesc serialVersionUID=1 local class
serialVersionUID=5311697006485595647
java.io.InvalidClassException:
org.apache.commons.collections.NodeCachingLinkedList; Local class not
compatible: stream classdesc serialVersionUID=1 local class
serialVersionUID=5311697006485595647
at
java.io.ObjectStreamClass.validateLocalClass(ObjectStreamClass.java:523)
at java.io.ObjectStreamClass.setClass(ObjectStreamClass.java:567)
at
java.io.ObjectInputStream.inputClassDescriptor(ObjectInputStream.java:936)
at
java.io.ObjectInputStream.readObject(ObjectInputStream.java:366)
at
java.io.ObjectInputStream.readObject(ObjectInputStream.java:236)
at
java.io.ObjectInputStream.inputObject(ObjectInputStream.java:1186)
at
java.io.ObjectInputStream.readObject(ObjectInputStream.java:386)
at
java.io.ObjectInputStream.readObject(ObjectInputStream.java:236)
at
org.apache.commons.collections.TestObject.readExternalFormFromStream(TestObject.java:186)
at
org.apache.commons.collections.TestObject.readExternalFormFromDisk(TestObject.java:202)
at
org.apache.commons.collections.TestList.testEmptyListCompatibility(TestList.java:894)
Testcase: testEmptyListCompatibilityTestcase: testFullListCompatibility
took 0.06 sec
Caused an ERROR
org.apache.commons.collections.NodeCachingLinkedList; Local class not
compatible: stream classdesc serialVersionUID=1 local class
serialVersionUID=5311697006485595647
java.io.InvalidClassException:
org.apache.commons.collections.NodeCachingLinkedList; Local class not
compatible: stream classdesc serialVersionUID=1 local class
serialVersionUID=5311697006485595647
at
java.io.ObjectStreamClass.validateLocalClass(ObjectStreamClass.java:523)
at java.io.ObjectStreamClass.setClass(ObjectStreamClass.java:567)
at
java.io.ObjectInputStream.inputClassDescriptor(ObjectInputStream.java:936)
at
java.io.ObjectInputStream.readObject(ObjectInputStream.java:366)
at
java.io.ObjectInputStream.readObject(ObjectInputStream.java:236)
at
java.io.ObjectInputStream.inputObject(ObjectInputStream.java:1186)
at
java.io.ObjectInputStream.readObject(ObjectInputStream.java:386)
at
java.io.ObjectInputStream.readObject(ObjectInputStream.java:236)
at
org.apache.commons.collections.TestObject.readExternalFormFromStream(TestObject.java:186)
at
org.apache.commons.collections.TestObject.readExternalFormFromDisk(TestObject.java:202)
at
org.apache.commons.collections.TestList.testFullListCompatibility(TestList.java:913)
On 5 Jan 2003, Rich Dougherty wrote:
> Here's a repost of a patch which will fix this. Note that the
> reimplementation of java.util.LinkedList is necessary so we can override
> node creation and deletion without using Sun's code.
>
> Rich
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [collections] unit test failures with NodeCachingLinkedList
Posted by Rich Dougherty <ri...@rd.gen.nz>.
Here's a repost of a patch which will fix this. Note that the
reimplementation of java.util.LinkedList is necessary so we can override
node creation and deletion without using Sun's code.
Rich