You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/27 06:37:39 UTC

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #18212: [improve] [client] Add api to get producer/consumer stats for partition topic

AnonHxy commented on code in PR #18212:
URL: https://github.com/apache/pulsar/pull/18212#discussion_r1006451057


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerStatsDisabled.java:
##########
@@ -145,7 +146,12 @@ public void reset() {
     }
 
     @Override
-    public void updateCumulativeStats(ConsumerStats stats) {
+    public void updateCumulativeStats(String partition, ConsumerStats stats) {

Review Comment:
   1. If we change the method singuture, I'm not sure will it bring some compatible problem, because this method is public.
   
   2. The name of this method is  `updateCumulativeStats`,  doing some partitioned stats work is not `cumulative` I think.  How about add a new method like `updatePartitionedStats()` :)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org