You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/19 09:10:48 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #13556: ARROW-17021:[C++][R][CI] Enable use of sccache in crossbow WIP

pitrou commented on code in PR #13556:
URL: https://github.com/apache/arrow/pull/13556#discussion_r924255831


##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -111,7 +111,10 @@ if(ARROW_DEFINE_OPTIONS)
 
   define_option(ARROW_POSITION_INDEPENDENT_CODE
                 "Whether to create position-independent target" ON)
-
+  
+  define_option(ARROW_USE_SCCACHE "Use sccache when compiling (if available), takes precdence\
+   over ccache" ON)

Review Comment:
   Hmm, I think we might want to leave this off by default, since sccache requires configuring unlike ccache? Just because the binary is installed on the machine doesn't mean it's actually usable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org