You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/01/18 12:23:30 UTC

[GitHub] [ignite] nizhikov commented on a change in pull request #8635: IGNITE-13958 .NET: Implicit binary type registration in Compute API

nizhikov commented on a change in pull request #8635:
URL: https://github.com/apache/ignite/pull/8635#discussion_r559529745



##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/Marshaller.cs
##########
@@ -109,6 +108,10 @@ public Marshaller(BinaryConfiguration cfg, ILogger log = null)
             if (typeNames != null)
                 foreach (string typeName in typeNames)
                     AddUserType(new BinaryTypeConfiguration(typeName), typeResolver);
+
+            _registerSameJavaType = _cfg.NameMapper == null || 

Review comment:
       OK. I removed changes for Cache API.
   We will discuss it later in the follow-ups of this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org