[impala] 02/03: IMPALA-10715: test decimal min max filters failed in exhaustive run

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 5c5708114c685f9d99d4b4c1e842bf0f11bfeb84
Author: Qifan Chen <qc...@cloudera.com>
AuthorDate: Wed Oct 12 13:08:47 2022 -0400

    IMPALA-10715: test decimal min max filters failed in exhaustive run
    
    This patch enables only the min/max filters in decimal min/max filter
    test so that some of the non-qualifying rows can be returned from the
    kudu scanners. Previously, the tests allows bloom filters to filter
    out rows at the kudu scanner level which prevents non-qualfying rows
    to arrive at the hash join node. Such non-qualifying rows are required
    by the test.
    
    With the patch, the test passes in the exhaustive mode. The patch also
    refactors the above logic for the entire TestMinMaxFilters test so that
    each test case in it will only get the min/max filter.
    
    Testing:
     - Unit test
     - Core test
    
    Change-Id: I20da28f780a27c6fdd917116e7c14d46d2a5db0f
    Reviewed-on: http://gerrit.cloudera.org:8080/19132
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_runtime_filters.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/query_test/test_runtime_filters.py b/tests/query_test/test_runtime_filters.py
index e48289bd0..c285a1335 100644
--- a/tests/query_test/test_runtime_filters.py
+++ b/tests/query_test/test_runtime_filters.py
@@ -220,9 +220,12 @@ class TestMinMaxFilters(ImpalaTestSuite):
     # Enable query option ASYNC_CODEGEN for slow build
     if build_runs_slowly:
       add_exec_option_dimension(cls, "async_codegen", 1)
+    # IMPALA-10715. Enable only min/max since the bloom filters will return
+    # rows only satisfying the join predicates. This test requires the return
+    # of non-qualifying rows to succeed.
+    add_exec_option_dimension(cls, "ENABLED_RUNTIME_FILTER_TYPES", "MIN_MAX")
 
   def test_min_max_filters(self, vector):
-    self.execute_query("SET ENABLED_RUNTIME_FILTER_TYPES=MIN_MAX")
     self.execute_query("SET MINMAX_FILTER_THRESHOLD=0.5")
     self.run_test_case('QueryTest/min_max_filters', vector,
         test_file_vars={'$RUNTIME_FILTER_WAIT_TIME_MS': str(WAIT_TIME_MS)})