You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/14 04:46:17 UTC
[GitHub] [airflow] uranusjr opened a new pull request #18224: Emit explicit exception if user fails to add due to db errors
uranusjr opened a new pull request #18224:
URL: https://github.com/apache/airflow/pull/18224
Fix #18204.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #18224: Return explicit error on user-add for duplicated email
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #18224:
URL: https://github.com/apache/airflow/pull/18224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18224: Emit explicit exception if user fails to add due to duplicated email
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18224:
URL: https://github.com/apache/airflow/pull/18224#issuecomment-918975923
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #18224: Emit explicit exception if user fails to add due to duplicated email
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #18224:
URL: https://github.com/apache/airflow/pull/18224#discussion_r708125970
##########
File path: tests/test_utils/api_connexion_utils.py
##########
@@ -18,19 +18,22 @@
from airflow.www.security import EXISTING_ROLES
-def create_user(app, username, role_name, permissions=None):
+def create_user(app, username, role_name, email=None, permissions=None):
appbuilder = app.appbuilder
# Removes user and role so each test has isolated test data.
delete_user(app, username)
delete_role(app, role_name)
role = create_role(app, role_name, permissions)
+ if email is None:
+ email = f"{username}@fab.org"
Review comment:
```suggestion
email = f"{username}@example.org"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org