[jira] [Commented] (SOLR-13366) 'Invalid stage name' warnings after upgrade

["Christine Poerschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808865#comment-16808865 ] 

Christine Poerschke commented on SOLR-13366:
--------------------------------------------

At a quick glance a small change in AutoScalingConfig.java e.g.
{code:java}
- LOG.warn("Invalid stage name '" + name + "' in listener config, skipping: " + properties);
+ LOG.warn("Invalid stage name '" + stageName + "' in listener config, skipping: " + properties);
{code}
could make it more apparent that {{WAITING}} is the invalid stage.

And upon further consideration the {{skipping: " + properties}} could be rephrased perhaps since the code appears to skip only the invalid stage but not the other stages i.e. not all of the properties are being skipped.

> 'Invalid stage name' warnings after upgrade
> -------------------------------------------
>
>                 Key: SOLR-13366
>                 URL: https://issues.apache.org/jira/browse/SOLR-13366
>             Project: Solr
>          Issue Type: Bug
>          Components: AutoScaling
>            Reporter: Christine Poerschke
>            Priority: Minor
>
> I noticed WARNings like this in some of our logs:
> {code:java}
> ... OverseerAutoScalingTriggerThread ... o.a.s.c.s.c.a.AutoScalingConfig Invalid stage name '.auto_add_replicas.system' in listener config, skipping: {beforeAction=[], afterAction=[], trigger=.auto_add_replicas, stage=[WAITING, STARTED, ABORTED, SUCCEEDED, FAILED, BEFORE_ACTION, AFTER_ACTION], class=org.apache.solr.cloud.autoscaling.SystemLogListener}
> {code}
> After some detective work I think I've tracked this down to 7.1.0 [TriggerEventProcessorStage|https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/TriggerEventProcessorStage.java] having a {{WAITING}} stage and that stage having been removed in 7.2.0 [TriggerEventProcessorStage|https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.2.0/solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/TriggerEventProcessorStage.java] via the SOLR-11320 changes. Haven't tried to reproduce it but my theory is that the listener got auto-created (with the {{WAITING}} stage) when the cloud was running pre-7.2.0 code and then after upgrading the warnings start to appear.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org